qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
	gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v4 10/33] hostmem-file: clean up memory allocation
Date: Mon, 19 Oct 2015 08:53:56 +0800	[thread overview]
Message-ID: <1445216059-88521-11-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com>

- hostmem-file.c is compiled only if CONFIG_LINUX is enabled so that is
  unnecessary to do the same check in the source file

- the interface, HostMemoryBackendClass->alloc(), is not called many
  times, do not need to check if the memory-region is initialized

Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
 backends/hostmem-file.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index e9b6d21..9097a57 100644
--- a/backends/hostmem-file.c
+++ b/backends/hostmem-file.c
@@ -46,17 +46,12 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
         error_setg(errp, "mem-path property not set");
         return;
     }
-#ifndef CONFIG_LINUX
-    error_setg(errp, "-mem-path not supported on this host");
-#else
-    if (!memory_region_size(&backend->mr)) {
-        backend->force_prealloc = mem_prealloc;
-        memory_region_init_ram_from_file(&backend->mr, OBJECT(backend),
+
+    backend->force_prealloc = mem_prealloc;
+    memory_region_init_ram_from_file(&backend->mr, OBJECT(backend),
                                  object_get_canonical_path(OBJECT(backend)),
                                  backend->size, fb->share,
                                  fb->mem_path, errp);
-    }
-#endif
 }
 
 static void
-- 
1.8.3.1

  parent reply	other threads:[~2015-10-18 16:59 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19  0:53 [Qemu-devel] [PATCH v4 00/33] implement vNVDIMM Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 01/33] acpi: add aml_derefof Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 02/33] acpi: add aml_sizeof Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 03/33] acpi: add aml_create_field Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 04/33] acpi: add aml_concatenate Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 05/33] acpi: add aml_object_type Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 06/33] acpi: add aml_method_serialized Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 07/33] util: introduce qemu_file_get_page_size() Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 08/33] exec: allow memory to be allocated from any kind of path Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 09/33] exec: allow file_ram_alloc to work on file Xiao Guangrong
2015-10-19  0:53 ` Xiao Guangrong [this message]
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 11/33] hostmem-file: use whole file size if possible Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 12/33] pc-dimm: remove DEFAULT_PC_DIMMSIZE Xiao Guangrong
2015-10-19  0:53 ` [Qemu-devel] [PATCH v4 13/33] pc-dimm: make pc_existing_dimms_capacity static and rename it Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 14/33] pc-dimm: drop the prefix of pc-dimm Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 15/33] stubs: rename qmp_pc_dimm_device_list.c Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 16/33] pc-dimm: rename pc-dimm.c and pc-dimm.h Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 17/33] dimm: abstract dimm device from pc-dimm Xiao Guangrong
2015-10-24  3:20   ` Bharata B Rao
2015-10-28 14:31     ` Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 18/33] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 19/33] dimm: keep the state of the whole backend memory Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 20/33] dimm: introduce realize callback Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 21/33] nvdimm: implement NVDIMM device abstract Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 22/33] docs: add NVDIMM ACPI documentation Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 23/33] nvdimm acpi: init the address region used by NVDIMM ACPI Xiao Guangrong
2015-10-18 17:15   ` Michael S. Tsirkin
2015-10-19  3:58     ` Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 24/33] nvdimm acpi: build ACPI NFIT table Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 25/33] nvdimm acpi: init the address region used by DSM Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 26/33] nvdimm acpi: build ACPI nvdimm devices Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method Xiao Guangrong
2015-10-18 17:16   ` Michael S. Tsirkin
2015-10-19  4:04     ` Xiao Guangrong
2015-10-19  6:57       ` Michael S. Tsirkin
2015-10-19  7:09       ` Michael S. Tsirkin
2015-10-19 17:29         ` Dan Williams
2015-10-19 21:19           ` Michael S. Tsirkin
2015-10-19 21:29             ` Dan Williams
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function Xiao Guangrong
2015-10-18 18:05   ` Michael S. Tsirkin
2015-10-19  4:39     ` Xiao Guangrong
2015-10-19  7:06       ` Michael S. Tsirkin
2015-10-19  7:39         ` Xiao Guangrong
2015-10-20 15:51   ` Stefan Hajnoczi
2015-10-20 16:05     ` Michael S. Tsirkin
2015-10-20 16:26     ` Xiao Guangrong
2015-10-20 16:29       ` Xiao Guangrong
2015-10-21 10:49       ` Stefan Hajnoczi
2015-10-21 13:32         ` Xiao Guangrong
2015-10-29 14:36           ` Igor Mammedov
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 29/33] nvdimm acpi: support DSM_DEV_FUN_NAMESPACE_LABEL_SIZE function Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 30/33] nvdimm acpi: support DSM_DEV_FUN_GET_NAMESPACE_LABEL_DATA Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 31/33] nvdimm acpi: support DSM_DEV_FUN_SET_NAMESPACE_LABEL_DATA Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 32/33] nvdimm: allow using whole backend memory as pmem Xiao Guangrong
2015-10-19  0:54 ` [Qemu-devel] [PATCH v4 33/33] nvdimm: add maintain info Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445216059-88521-11-git-send-email-guangrong.xiao@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).