From: Gerd Hoffmann <kraxel@redhat.com>
To: Julio Faracco <jcfaracco@gmail.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qapi: Adding websocket information inside VncInfo structure.
Date: Mon, 19 Oct 2015 10:17:07 +0200 [thread overview]
Message-ID: <1445242627.13733.11.camel@redhat.com> (raw)
In-Reply-To: <1445013460-21104-1-git-send-email-jcfaracco@gmail.com>
Hi,
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a386605..e97f78f 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -916,7 +916,8 @@
> { 'struct': 'VncInfo',
> 'data': {'enabled': 'bool', '*host': 'str',
> '*family': 'NetworkAddressFamily',
> - '*service': 'str', '*auth': 'str', '*clients': ['VncClientInfo']} }
> + '*service': 'str', '*auth': 'str', '*clients': ['VncClientInfo'],
> + '*webservice': 'str', 'has_websocket': 'bool'} }
>
> ##
> # @VncPriAuth:
Please leave VncInfo alone. There is VncInfo2 which should fill all
your needs.
You might consider switching hmp_info_vnc() to use the new
qmp_query_vnc_servers() instead of the old qmp_query_vnc().
cheers,
Gerd
next prev parent reply other threads:[~2015-10-19 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 16:37 [Qemu-devel] [PATCH] qapi: Adding websocket information inside VncInfo structure Julio Faracco
2015-10-16 16:50 ` Eric Blake
2015-10-19 8:17 ` Gerd Hoffmann [this message]
2015-10-19 23:47 ` Julio Faracco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445242627.13733.11.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=jcfaracco@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).