From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52071)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zo7Su-0002uZ-SA
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 06:14:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zo7Sr-0007V6-Lc
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 06:14:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47039)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zo7Sr-0007V1-G9
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 06:14:49 -0400
Message-ID: <1445249686.13733.28.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 19 Oct 2015 12:14:46 +0200
In-Reply-To: <87y4f45uer.fsf@mail.parknet.co.jp>
References: <87k2qp8yxv.fsf@mail.parknet.co.jp>
	<87fv1d8ywp.fsf@mail.parknet.co.jp>
	<87bnc18yvw.fsf_-_@mail.parknet.co.jp>
	<1444837495.4467.29.camel@redhat.com>
	<87y4f56lzu.fsf@mail.parknet.co.jp>
	<1444895333.24283.7.camel@redhat.com>
	<87a8rk7d5q.fsf@mail.parknet.co.jp>
	<8761287by3.fsf@mail.parknet.co.jp>
	<1444900391.24283.17.camel@redhat.com>
	<87y4f45uer.fsf@mail.parknet.co.jp>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars
 on -curses mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: qemu-devel@nongnu.org

  Hi,

> OK. For cleaner (purpose is separation of curses code), I introduced
> hw_text_update_cb() interface (looks like possible to use text data for
> other than curses interface too). But you may feel this is overkill.

Waded through the code a bit.  The whole text interface isn't cleanly
abstracted.  There are curses-specific assumptions all over the place
and thats why there is a curses include in console.h (ideally there
shouldn't be any outside ui/curses.c).

So I've changed my mind and I think adding this interface doesn't help
much.  It pretends we have a clean text mode interface, which we clearly
don't have.  Tex mode support needs some major work anyway should we add
a second text mode interface at some point in the future.  Using
vga_to_curses in console.c makes at least pretty clear what is going on
here.

Lets go with v2 of this patch.

There are some codestyle issues in the patch (and the others too),
please fix them them (scripts/checkpatch.pl helps), then resend the
whole series.

thanks,
  Gerd