From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoA7O-0007xD-RE for qemu-devel@nongnu.org; Mon, 19 Oct 2015 09:04:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoA7J-00055j-QO for qemu-devel@nongnu.org; Mon, 19 Oct 2015 09:04:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoA7J-00055c-Lq for qemu-devel@nongnu.org; Mon, 19 Oct 2015 09:04:45 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 018148EA37 for ; Mon, 19 Oct 2015 13:04:43 +0000 (UTC) From: Vladislav Yasevich Date: Mon, 19 Oct 2015 09:04:38 -0400 Message-Id: <1445259878-3921-1-git-send-email-vyasevic@redhat.com> Subject: [Qemu-devel] [PATCH] net: Remove duplicate data from query-rx-filter on multiqueue net devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Vladislav Yasevich , jasowang@redhat.com, stefanha@redhat.com When responding to a query-rx-filter command on a multiqueue netdev, qemu reports the data for each queue. The data, however, is not per-queue, but per device and the same data is reported multiple times. This causes confusion and may also cause extra unnecessary processing when looking at the data. Commit 638fb14169 (net: Make qmp_query_rx_filter() with name argument more obvious) partially addresses this issue, by limiting the output when the name is specified. However, when the name is not specified, the issue still persists. Signed-off-by: Vladislav Yasevich --- net/net.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/net.c b/net/net.c index 39af893..a8cfeba 100644 --- a/net/net.c +++ b/net/net.c @@ -1219,6 +1219,12 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, continue; } + /* only query information on queue 0 since the info is per nic, + * not per queue + */ + if (nc->queue_index != 0) + continue; + if (nc->info->query_rx_filter) { info = nc->info->query_rx_filter(nc); entry = g_malloc0(sizeof(*entry)); -- 1.9.3