From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59400)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZoAUv-0006g6-Cp
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 09:29:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZoAUs-00056L-5S
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 09:29:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52501)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZoAUs-000561-0N
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 09:29:06 -0400
Message-ID: <1445261343.13733.41.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 19 Oct 2015 15:29:03 +0200
In-Reply-To: <20151019115234.GA5874@morn.lan>
References: <1445246284-21137-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA_E-W5zvOmwO1ePFF7O2Y+2vVw-ShF2AtSnh90gSUoQyQ@mail.gmail.com>
	<20151019115234.GA5874@morn.lan>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface,
 add strings via cmdline.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

  Hi

> > Windows fails to compile:
> > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function
> > =E2=80=98fw_cfg_dma_mem_read=E2=80=99:
> > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning:
> > integer constant is too large for =E2=80=98long=E2=80=99 type
>=20
> I don't have a Windows test environment, but I suspect the following:

Builds fine here for some strange reason ...

> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */
>=20
> should be changed to:
>=20
> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */

But that is correct.  Fixed.

cheers,
  Gerd