[Qemu-devel] [PATCH] seccomp: loosen library version dependency

[Qemu-devel] [PATCH] seccomp: loosen library version dependency

[dann frazier]

Drop the libseccomp required version back to 2.1.0, restoring the ability
to build w/ --enable-seccomp on Ubuntu 14.04.

Commit 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69 tightened the dependency
on libseccomp from version 2.1.0 to 2.1.1. This broke building on Ubuntu
14.04, the current Ubuntu LTS release. The commit message didn't mention
any specific functional need for 2.1.1, just that it was the most recent
stable version at the time. I reviewed the changes between 2.1.0 and 2.1.1,
but it looks like that update just contained minor fixes and cleanups - no
obvious (to me) new interfaces or critical bug fixes.

Signed-off-by: dann frazier <dann.frazier@canonical.com>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 913ae4a..b6f4694 100755
--- a/configure
+++ b/configure
@@ -1873,13 +1873,13 @@ fi
 
 if test "$seccomp" != "no" ; then
     if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
-        $pkg_config --atleast-version=2.1.1 libseccomp; then
+        $pkg_config --atleast-version=2.1.0 libseccomp; then
         libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
         QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
 	seccomp="yes"
     else
 	if test "$seccomp" = "yes"; then
-            feature_not_found "libseccomp" "Install libseccomp devel >= 2.1.1"
+            feature_not_found "libseccomp" "Install libseccomp devel >= 2.1.0"
 	fi
 	seccomp="no"
     fi
-- 
2.6.1

Re: [Qemu-devel] [PATCH] seccomp: loosen library version dependency

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1975 bytes --]

On Mon, Oct 19, 2015 at 02=58=51PM -0600, dann frazier wrote:
> Drop the libseccomp required version back to 2.1.0, restoring the ability
> to build w/ --enable-seccomp on Ubuntu 14.04.
> 
> Commit 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69 tightened the dependency
> on libseccomp from version 2.1.0 to 2.1.1. This broke building on Ubuntu
> 14.04, the current Ubuntu LTS release. The commit message didn't mention
> any specific functional need for 2.1.1, just that it was the most recent
> stable version at the time. I reviewed the changes between 2.1.0 and 2.1.1,
> but it looks like that update just contained minor fixes and cleanups - no
> obvious (to me) new interfaces or critical bug fixes.

The patch looks good to me, but can you rebase your work on top of this
patch? https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg03168.html

Then I can put you on the pipeline for the next pullrequest more easily.

Thanks for the contribution.

> 
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 913ae4a..b6f4694 100755
> --- a/configure
> +++ b/configure
> @@ -1873,13 +1873,13 @@ fi
>  
>  if test "$seccomp" != "no" ; then
>      if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> -        $pkg_config --atleast-version=2.1.1 libseccomp; then
> +        $pkg_config --atleast-version=2.1.0 libseccomp; then
>          libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
>          QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
>  	seccomp="yes"
>      else
>  	if test "$seccomp" = "yes"; then
> -            feature_not_found "libseccomp" "Install libseccomp devel >= 2.1.1"
> +            feature_not_found "libseccomp" "Install libseccomp devel >= 2.1.0"
>  	fi
>  	seccomp="no"
>      fi
> -- 
> 2.6.1
> 

-- 
Eduardo Otubo
ProfitBricks GmbH

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[Qemu-devel] [PATCH] seccomp: loosen library version dependency

[dann frazier]

Drop the libseccomp required version back to 2.1.0, restoring the ability
to build w/ --enable-seccomp on Ubuntu 14.04.

Commit 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69 tightened the dependency
on libseccomp from version 2.1.0 to 2.1.1. This broke building on Ubuntu
14.04, the current Ubuntu LTS release. The commit message didn't mention
any specific functional need for 2.1.1, just that it was the most recent
stable version at the time. I reviewed the changes between 2.1.0 and 2.1.1,
but it looks like that update just contained minor fixes and cleanups - no
obvious (to me) new interfaces or critical bug fixes.

Signed-off-by: dann frazier <dann.frazier@canonical.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 7d5aab2..8a9794b 100755
--- a/configure
+++ b/configure
@@ -1878,7 +1878,7 @@ fi
 if test "$seccomp" != "no" ; then
     case "$cpu" in
     i386|x86_64)
-        libseccomp_minver="2.1.1"
+        libseccomp_minver="2.1.0"
         ;;
     arm|aarch64)
         libseccomp_minver="2.2.3"
-- 
2.6.1