qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
	qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v4 08/12] block: Add "drained begin/end" for transactional blockdev-backup
Date: Tue, 20 Oct 2015 13:16:59 +0800	[thread overview]
Message-ID: <1445318223-30055-9-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1445318223-30055-1-git-send-email-famz@redhat.com>

Similar to the previous patch, make sure that external events are not
dispatched during transaction operations.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 blockdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/blockdev.c b/blockdev.c
index e3e68e6..6ab98e3 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1678,6 +1678,8 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp)
         return;
     }
     aio_context_acquire(state->aio_context);
+    state->bs = bs;
+    bdrv_drained_begin(bs);
 
     qmp_blockdev_backup(backup->device, backup->target,
                         backup->sync,
@@ -1690,7 +1692,6 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp)
         return;
     }
 
-    state->bs = bs;
     state->job = state->bs->job;
 }
 
@@ -1710,6 +1711,7 @@ static void blockdev_backup_clean(BlkTransactionState *common)
     BlockdevBackupState *state = DO_UPCAST(BlockdevBackupState, common, common);
 
     if (state->aio_context) {
+        bdrv_drained_end(state->bs);
         aio_context_release(state->aio_context);
     }
 }
-- 
2.4.3

  parent reply	other threads:[~2015-10-20  5:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20  5:16 [Qemu-devel] [PATCH v4 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end Fam Zheng
2015-10-20  5:16 ` [Qemu-devel] [PATCH v4 01/12] aio: Add "is_external" flag for event handlers Fam Zheng
2015-10-20  5:16 ` [Qemu-devel] [PATCH v4 02/12] nbd: Mark fd handlers client type as "external" Fam Zheng
2015-10-20  5:16 ` [Qemu-devel] [PATCH v4 03/12] dataplane: Mark host notifiers' " Fam Zheng
2015-10-20  5:16 ` [Qemu-devel] [PATCH v4 04/12] aio: introduce aio_{disable, enable}_external Fam Zheng
2015-10-20  5:16 ` [Qemu-devel] [PATCH v4 05/12] block: Introduce "drained begin/end" API Fam Zheng
2015-10-20  5:16 ` [Qemu-devel] [PATCH v4 06/12] block: Add "drained begin/end" for transactional external snapshot Fam Zheng
2015-10-20  5:16 ` [Qemu-devel] [PATCH v4 07/12] block: Add "drained begin/end" for transactional backup Fam Zheng
2015-10-20  5:16 ` Fam Zheng [this message]
2015-10-20  5:17 ` [Qemu-devel] [PATCH v4 09/12] block: Add "drained begin/end" for internal snapshot Fam Zheng
2015-10-20  5:17 ` [Qemu-devel] [PATCH v4 10/12] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-10-20  5:17 ` [Qemu-devel] [PATCH v4 11/12] qed: Implement .bdrv_drain Fam Zheng
2015-10-20  5:17 ` [Qemu-devel] [PATCH v4 12/12] tests: Add test case for aio_disable_external Fam Zheng
2015-10-20 14:17 ` [Qemu-devel] [PATCH v4 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end Kevin Wolf
2015-10-21  1:18   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445318223-30055-9-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).