From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoQ9B-0003Aq-3M for qemu-devel@nongnu.org; Tue, 20 Oct 2015 02:11:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoQ97-0003Gl-U1 for qemu-devel@nongnu.org; Tue, 20 Oct 2015 02:11:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoQ97-0003GQ-Oh for qemu-devel@nongnu.org; Tue, 20 Oct 2015 02:11:41 -0400 From: Gerd Hoffmann Date: Tue, 20 Oct 2015 08:11:27 +0200 Message-Id: <1445321492-2902-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1445321492-2902-1-git-send-email-kraxel@redhat.com> References: <1445321492-2902-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL v2 2/7] fw_cfg: document fw_cfg_modify_iXX() update functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Gabriel L. Somlo" , Gerd Hoffmann From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- docs/specs/fw_cfg.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt index c0e76aa..d5dee4b 100644 --- a/docs/specs/fw_cfg.txt +++ b/docs/specs/fw_cfg.txt @@ -159,6 +159,17 @@ will convert a 16-, 32-, or 64-bit integer to little-endian, then add a dynamically allocated copy of the appropriately sized item to fw_cfg under the given selector key value. +== fw_cfg_modify_iXX() == + +Modify the value of an XX-bit item (where XX may be 16, 32, or 64). +Similarly to the corresponding fw_cfg_add_iXX() function set, convert +a 16-, 32-, or 64-bit integer to little endian, create a dynamically +allocated copy of the required size, and replace the existing item at +the given selector key value with the newly allocated one. The previous +item, assumed to have been allocated during an earlier call to +fw_cfg_add_iXX() or fw_cfg_modify_iXX() (of the same width XX), is freed +before the function returns. + == fw_cfg_add_file() == Given a filename (i.e., fw_cfg item name), starting pointer, and size, -- 1.8.3.1