qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 01/10] tcg/ppc: Adjust exit_tb for change in prologue placement
Date: Wed, 21 Oct 2015 11:42:50 -1000	[thread overview]
Message-ID: <1445463779-5823-2-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1445463779-5823-1-git-send-email-rth@twiddle.net>

Changing the prologue to the beginning of the code_gen_buffer
changes the direction of the "return" branch.  Need to change
the logic to match.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/ppc/tcg-target.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c
index 92ef719..fd7a3e0 100644
--- a/tcg/ppc/tcg-target.c
+++ b/tcg/ppc/tcg-target.c
@@ -1855,12 +1855,10 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args,
         if (USE_REG_RA) {
             ptrdiff_t disp = tcg_pcrel_diff(s, tb_ret_addr);
 
-            /* If we can use a direct branch, otherwise use the value in RA.
-               Note that the direct branch is always forward.  If it's in
-               range now, it'll still be in range after the movi.  Don't
-               bother about the 20 bytes where the test here fails but it
-               would succeed below.  */
-            if (!in_range_b(disp)) {
+            /* Use a direct branch if we can, otherwise use the value in RA.
+               Note that the direct branch is always backward, thus we need
+               to account for the possibility of 5 insns from the movi.  */
+            if (!in_range_b(disp - 20)) {
                 tcg_out32(s, MTSPR | RS(TCG_REG_RA) | CTR);
                 tcg_out_movi(s, TCG_TYPE_PTR, TCG_REG_R3, args[0]);
                 tcg_out32(s, BCCTR | BO_ALWAYS);
-- 
2.4.3

  reply	other threads:[~2015-10-21 21:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 21:42 [Qemu-devel] [PULL 00/10] collected tcg patches Richard Henderson
2015-10-21 21:42 ` Richard Henderson [this message]
2015-10-21 21:42 ` [Qemu-devel] [PULL 02/10] tcg/ppc: Revise goto_tb implementation Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 03/10] tcg/ppc: Prefer mask over andi Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 04/10] tcg-opc.h: Simplify insn_start def Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 05/10] disas/mips: Add R6 jr/jr.hb to disassembler Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 06/10] tcg/mips: Add use_mips32r6_instructions definition Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 07/10] tcg/mips: Support r6 JR encoding Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 08/10] tcg/mips: Support r6 multiply/divide encodings Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 09/10] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 10/10] cpu-exec: Add "nochain" debug flag Richard Henderson
2015-10-22  6:34   ` Edgar E. Iglesias
2015-10-22 11:02 ` [Qemu-devel] [PULL 00/10] collected tcg patches Peter Maydell
2015-10-22 17:47   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445463779-5823-2-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).