qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, James Hogan <james.hogan@imgtec.com>
Subject: [Qemu-devel] [PULL 04/10] tcg-opc.h: Simplify insn_start def
Date: Wed, 21 Oct 2015 11:42:53 -1000	[thread overview]
Message-ID: <1445463779-5823-5-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1445463779-5823-1-git-send-email-rth@twiddle.net>

From: James Hogan <james.hogan@imgtec.com>

We already have a TLADDR_ARGS definition, so rearrange the order
slightly and use it in the definition of insn_start, instead of
having an #ifdef.

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Message-Id: <1443788657-14537-2-git-send-email-james.hogan@imgtec.com>
---
 tcg/tcg-opc.h | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h
index c6f9570..6d0410c 100644
--- a/tcg/tcg-opc.h
+++ b/tcg/tcg-opc.h
@@ -173,18 +173,15 @@ DEF(muls2_i64, 2, 2, 0, IMPL64 | IMPL(TCG_TARGET_HAS_muls2_i64))
 DEF(muluh_i64, 1, 2, 0, IMPL(TCG_TARGET_HAS_muluh_i64))
 DEF(mulsh_i64, 1, 2, 0, IMPL(TCG_TARGET_HAS_mulsh_i64))
 
+#define TLADDR_ARGS  (TARGET_LONG_BITS <= TCG_TARGET_REG_BITS ? 1 : 2)
+#define DATA64_ARGS  (TCG_TARGET_REG_BITS == 64 ? 1 : 2)
+
 /* QEMU specific */
-#if TARGET_LONG_BITS > TCG_TARGET_REG_BITS
-DEF(insn_start, 0, 0, 2 * TARGET_INSN_START_WORDS, TCG_OPF_NOT_PRESENT)
-#else
-DEF(insn_start, 0, 0, TARGET_INSN_START_WORDS, TCG_OPF_NOT_PRESENT)
-#endif
+DEF(insn_start, 0, 0, TLADDR_ARGS * TARGET_INSN_START_WORDS,
+    TCG_OPF_NOT_PRESENT)
 DEF(exit_tb, 0, 0, 1, TCG_OPF_BB_END)
 DEF(goto_tb, 0, 0, 1, TCG_OPF_BB_END)
 
-#define TLADDR_ARGS    (TARGET_LONG_BITS <= TCG_TARGET_REG_BITS ? 1 : 2)
-#define DATA64_ARGS  (TCG_TARGET_REG_BITS == 64 ? 1 : 2)
-
 DEF(qemu_ld_i32, 1, TLADDR_ARGS, 1,
     TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
 DEF(qemu_st_i32, 0, TLADDR_ARGS + 1, 1,
-- 
2.4.3

  parent reply	other threads:[~2015-10-21 21:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 21:42 [Qemu-devel] [PULL 00/10] collected tcg patches Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 01/10] tcg/ppc: Adjust exit_tb for change in prologue placement Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 02/10] tcg/ppc: Revise goto_tb implementation Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 03/10] tcg/ppc: Prefer mask over andi Richard Henderson
2015-10-21 21:42 ` Richard Henderson [this message]
2015-10-21 21:42 ` [Qemu-devel] [PULL 05/10] disas/mips: Add R6 jr/jr.hb to disassembler Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 06/10] tcg/mips: Add use_mips32r6_instructions definition Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 07/10] tcg/mips: Support r6 JR encoding Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 08/10] tcg/mips: Support r6 multiply/divide encodings Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 09/10] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ Richard Henderson
2015-10-21 21:42 ` [Qemu-devel] [PULL 10/10] cpu-exec: Add "nochain" debug flag Richard Henderson
2015-10-22  6:34   ` Edgar E. Iglesias
2015-10-22 11:02 ` [Qemu-devel] [PULL 00/10] collected tcg patches Peter Maydell
2015-10-22 17:47   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445463779-5823-5-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=james.hogan@imgtec.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).