From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=730db3765=Ian.Campbell@citrix.com>)
	id 1ZpDiM-0007YY-Rx
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 07:07:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=730db3765=Ian.Campbell@citrix.com>)
	id 1ZpDiJ-0007GU-1n
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 07:07:22 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:55302)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=730db3765=Ian.Campbell@citrix.com>)
	id 1ZpDiI-0007GI-Tc
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 07:07:18 -0400
Message-ID: <1445512036.9563.274.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Thu, 22 Oct 2015 12:07:16 +0100
In-Reply-To: <1445441038-25903-10-git-send-email-ian.campbell@citrix.com>
References: <1445440941.9563.163.camel@citrix.com>
	<1445441038-25903-1-git-send-email-ian.campbell@citrix.com>
	<1445441038-25903-10-git-send-email-ian.campbell@citrix.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to
 build without the Xen PV domain builder
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Cc: qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com

On Wed, 2015-10-21 at 16:23 +0100, Ian Campbell wrote:
> [...]
> v4: Fixed all checkpatch errors.
>     Disabled by default.

I botched this and it is no longer possible to turn it on. (I wonder if
anyone would have noticed in practice...)
> @@ -2113,6 +2117,15 @@ if test "$xen_pci_passthrough" != "no"; then
>    fi
>  fi
>  
> +if test "$xen_pv_domain_build" != "no"; then
> +  if test "$xen_pv_domain_build" = "yes" &&
> +     test "$xen" != "yes"; then
> +      error_exit "User requested Xen PV domain builder support" \
> +		 "which requires Xen support."
> +  fi
> +  xen_pv_domain_build=no
> +fi

This is bogus.

v5 will have this incremental fix in it:

diff --git a/configure b/configure
index b9c5d68..24cfd35 100755
--- a/configure
+++ b/configure
@@ -2117,13 +2117,13 @@ if test "$xen_pci_passthrough" != "no"; then
   fi
 fi
 
-if test "$xen_pv_domain_build" != "no"; then
-  if test "$xen_pv_domain_build" = "yes" &&
-     test "$xen" != "yes"; then
-      error_exit "User requested Xen PV domain builder support" \
-		 "which requires Xen support."
-  fi
-  xen_pv_domain_build=no
+if test "$xen_pv_domain_build" = "yes"; then
+    if test "$xen" != "yes"; then
+	error_exit "User requested Xen PV domain builder support" \
+		   "which requires Xen support."
+    fi
+else
+    xen_pv_domain_build=no
 fi
 
 ##########################################


Which is a bit easier to grok with -b:

diff --git a/configure b/configure
index b9c5d68..24cfd35 100755
--- a/configure
+++ b/configure
@@ -2117,12 +2117,12 @@ if test "$xen_pci_passthrough" != "no"; then
   fi
 fi
 
-if test "$xen_pv_domain_build" != "no"; then
-  if test "$xen_pv_domain_build" = "yes" &&
-     test "$xen" != "yes"; then
+if test "$xen_pv_domain_build" = "yes"; then
+    if test "$xen" != "yes"; then
 	error_exit "User requested Xen PV domain builder support" \
 		   "which requires Xen support."
     fi
+else
     xen_pv_domain_build=no
 fi