From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
"Anthony Green" <green@moxielogic.com>,
"Andreas Färber" <afaerber@suse.de>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PULL 2/8] disas: QOMify moxie specific disas setup
Date: Thu, 22 Oct 2015 18:22:33 +0200 [thread overview]
Message-ID: <1445530959-19309-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1445530959-19309-1-git-send-email-afaerber@suse.de>
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Move the target_disas() moxie specifics to the CPUClass::disas_set_info()
hook and delete the #ifdef specific code in disas.c.
Cc: Anthony Green <green@moxielogic.com>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
disas.c | 6 ------
target-moxie/cpu.c | 7 +++++++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/disas.c b/disas.c
index 655f23d..05d409b 100644
--- a/disas.c
+++ b/disas.c
@@ -249,9 +249,6 @@ void target_disas(FILE *out, CPUState *cpu, target_ulong code,
#elif defined(TARGET_ALPHA)
s.info.mach = bfd_mach_alpha_ev6;
s.info.print_insn = print_insn_alpha;
-#elif defined(TARGET_MOXIE)
- s.info.mach = bfd_arch_moxie;
- s.info.print_insn = print_insn_moxie;
#elif defined(TARGET_LM32)
s.info.mach = bfd_mach_lm32;
s.info.print_insn = print_insn_lm32;
@@ -459,9 +456,6 @@ void monitor_disas(Monitor *mon, CPUState *cpu,
#elif defined(TARGET_SH4)
s.info.mach = bfd_mach_sh4;
s.info.print_insn = print_insn_sh;
-#elif defined(TARGET_MOXIE)
- s.info.mach = bfd_arch_moxie;
- s.info.print_insn = print_insn_moxie;
#elif defined(TARGET_LM32)
s.info.mach = bfd_mach_lm32;
s.info.print_insn = print_insn_lm32;
diff --git a/target-moxie/cpu.c b/target-moxie/cpu.c
index 3af3779..0c60c65 100644
--- a/target-moxie/cpu.c
+++ b/target-moxie/cpu.c
@@ -48,6 +48,12 @@ static void moxie_cpu_reset(CPUState *s)
tlb_flush(s, 1);
}
+static void moxie_cpu_disas_set_info(CPUState *cpu, disassemble_info *info)
+{
+ info->mach = bfd_arch_moxie;
+ info->print_insn = print_insn_moxie;
+}
+
static void moxie_cpu_realizefn(DeviceState *dev, Error **errp)
{
CPUState *cs = CPU(dev);
@@ -114,6 +120,7 @@ static void moxie_cpu_class_init(ObjectClass *oc, void *data)
cc->get_phys_page_debug = moxie_cpu_get_phys_page_debug;
cc->vmsd = &vmstate_moxie_cpu;
#endif
+ cc->disas_set_info = moxie_cpu_disas_set_info;
/*
* Reason: moxie_cpu_initfn() calls cpu_exec_init(), which saves
--
2.1.4
next prev parent reply other threads:[~2015-10-22 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 16:22 [Qemu-devel] [PULL 0/8] QOM CPUState patch queue 2015-10-22 Andreas Färber
2015-10-22 16:22 ` [Qemu-devel] [PULL 1/8] disas: QOMify s390x specific disas setup Andreas Färber
2015-10-22 16:22 ` Andreas Färber [this message]
2015-10-22 16:22 ` [Qemu-devel] [PULL 3/8] disas: QOMify m68k " Andreas Färber
2015-10-22 16:22 ` [Qemu-devel] [PULL 4/8] disas: QOMify sparc " Andreas Färber
2015-10-22 16:22 ` [Qemu-devel] [PULL 5/8] disas: QOMify lm32 " Andreas Färber
2015-10-22 16:22 ` [Qemu-devel] [PULL 6/8] disas: QOMify sh4 " Andreas Färber
2015-10-22 16:22 ` [Qemu-devel] [PULL 7/8] disas: QOMify mips " Andreas Färber
2015-10-22 16:22 ` [Qemu-devel] [PULL 8/8] disas: QOMify alpha " Andreas Färber
2015-10-22 17:01 ` [Qemu-devel] [PULL 0/8] QOM CPUState patch queue 2015-10-22 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445530959-19309-3-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=green@moxielogic.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).