From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpIdi-0002D8-W5 for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:22:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpIde-0004JB-5j for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:22:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:48727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpIdd-0004IS-VC for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:22:50 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 22 Oct 2015 18:22:38 +0200 Message-Id: <1445530959-19309-8-git-send-email-afaerber@suse.de> In-Reply-To: <1445530959-19309-1-git-send-email-afaerber@suse.de> References: <1445530959-19309-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 7/8] disas: QOMify mips specific disas setup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Crosthwaite , Leon Alrae , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Aurelien Jarno , Peter Crosthwaite From: Peter Crosthwaite Move the target_disas() mips specifics to the CPUClass::disas_set_info() hook and delete the #ifdef specific code in disas.c. Cc: Aurelien Jarno Signed-off-by: Peter Crosthwaite Acked-by: Leon Alrae Signed-off-by: Andreas F=C3=A4rber --- disas.c | 12 ------------ target-mips/cpu.c | 9 +++++++++ 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/disas.c b/disas.c index 2676e2f..bf16c42 100644 --- a/disas.c +++ b/disas.c @@ -230,12 +230,6 @@ void target_disas(FILE *out, CPUState *cpu, target_u= long code, } s.info.disassembler_options =3D (char *)"any"; s.info.print_insn =3D print_insn_ppc; -#elif defined(TARGET_MIPS) -#ifdef TARGET_WORDS_BIGENDIAN - s.info.print_insn =3D print_insn_big_mips; -#else - s.info.print_insn =3D print_insn_little_mips; -#endif #elif defined(TARGET_ALPHA) s.info.mach =3D bfd_mach_alpha_ev6; s.info.print_insn =3D print_insn_alpha; @@ -427,12 +421,6 @@ void monitor_disas(Monitor *mon, CPUState *cpu, s.info.endian =3D BFD_ENDIAN_LITTLE; } s.info.print_insn =3D print_insn_ppc; -#elif defined(TARGET_MIPS) -#ifdef TARGET_WORDS_BIGENDIAN - s.info.print_insn =3D print_insn_big_mips; -#else - s.info.print_insn =3D print_insn_little_mips; -#endif #endif if (!s.info.print_insn) { monitor_printf(mon, "0x" TARGET_FMT_lx diff --git a/target-mips/cpu.c b/target-mips/cpu.c index 7fe1f04..37880d2 100644 --- a/target-mips/cpu.c +++ b/target-mips/cpu.c @@ -97,6 +97,14 @@ static void mips_cpu_reset(CPUState *s) #endif } =20 +static void mips_cpu_disas_set_info(CPUState *s, disassemble_info *info)= { +#ifdef TARGET_WORDS_BIGENDIAN + info->print_insn =3D print_insn_big_mips; +#else + info->print_insn =3D print_insn_little_mips; +#endif +} + static void mips_cpu_realizefn(DeviceState *dev, Error **errp) { CPUState *cs =3D CPU(dev); @@ -150,6 +158,7 @@ static void mips_cpu_class_init(ObjectClass *c, void = *data) cc->get_phys_page_debug =3D mips_cpu_get_phys_page_debug; cc->vmsd =3D &vmstate_mips_cpu; #endif + cc->disas_set_info =3D mips_cpu_disas_set_info; =20 cc->gdb_num_core_regs =3D 73; cc->gdb_stop_before_watchpoint =3D true; --=20 2.1.4