From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpaJT-0003hR-Ci for qemu-devel@nongnu.org; Fri, 23 Oct 2015 07:15:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpaJP-00066o-5e for qemu-devel@nongnu.org; Fri, 23 Oct 2015 07:15:11 -0400 Received: from smtp.citrix.com ([66.165.176.63]:50964 helo=SMTP02.CITRIX.COM) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpaJP-00064g-1a for qemu-devel@nongnu.org; Fri, 23 Oct 2015 07:15:07 -0400 Message-ID: <1445598904.2374.125.camel@citrix.com> From: Ian Campbell Date: Fri, 23 Oct 2015 12:15:04 +0100 In-Reply-To: References: <1445440941.9563.163.camel@citrix.com> <1445441038-25903-1-git-send-email-ian.campbell@citrix.com> <1445441038-25903-4-git-send-email-ian.campbell@citrix.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab interface for compat shims. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, qemu-devel@nongnu.org, xen-devel@lists.xen.org On Fri, 2015-10-23 at 12:06 +0100, Stefano Stabellini wrote: > On Wed, 21 Oct 2015, Ian Campbell wrote: > > In Xen 4.7 we are refactoring parts libxenctrl into a number of > > separate libraries which will provide backward and forward API and ABI > > compatiblity. > > > > One such library will be libxengnttab which provides access to grant > > tables. > > > > In preparation for this switch the compatibility layer in xen_common.h > > (which support building with older versions of Xen) to use what will > > be the new library API. This means that the gnttab shim will disappear > > for versions of Xen which include libxengnttab. > > > > To simplify things for the <= 4.0.0 support we wrap the int fd in a > > malloc(sizeof int) such that the handle is always a pointer. This > > leads to less typedef headaches and the need for > > XC_HANDLER_INITIAL_VALUE etc for these interfaces. > > > > Build tested with 4.0 and 4.5. > > > > Note that this patch does not add any support for actually using > > libxengnttab, it just adjusts the existing shims. > > > > Signed-off-by: Ian Campbell > > The patch looks OK but doesn't apply cleanly to master, please rebase. > After fixing it up, it fails my 4.0 build test (I probably made a > mistake). It was based on: commit 816609b2841297925a223ec377c336360e044ee5 Author: Gerd Hoffmann Date: Tue Jun 9 21:08:47 2015 +0200 spice-display: fix segfault in qemu_spice_create_update Ah, I'm pointing at our xenbits qemu upstream tree (master branch, not even upstream-tested) not the qemu.org one. I'll update to base on proper mainline for v5 next time. (I thought things were awfully quite on the incoming patches front when I ran git remote update!)