From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpeLf-0002FJ-Um for qemu-devel@nongnu.org; Fri, 23 Oct 2015 11:33:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpeLf-0001r9-3V for qemu-devel@nongnu.org; Fri, 23 Oct 2015 11:33:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpeLe-0001r4-Uw for qemu-devel@nongnu.org; Fri, 23 Oct 2015 11:33:43 -0400 From: Eduardo Habkost Date: Fri, 23 Oct 2015 13:33:06 -0200 Message-Id: <1445614392-26687-8-git-send-email-ehabkost@redhat.com> In-Reply-To: <1445614392-26687-1-git-send-email-ehabkost@redhat.com> References: <1445614392-26687-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 07/13] target-i386: Optimize setting dr[0-3] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson From: Richard Henderson If the debug register is not enabled, we need do nothing besides update the register. Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c index ca58ab7..7ff41a6 100644 --- a/target-i386/bpt_helper.c +++ b/target-i386/bpt_helper.c @@ -228,9 +228,14 @@ void helper_movl_drN_T0(CPUX86State *env, int reg, target_ulong t0) { #ifndef CONFIG_USER_ONLY if (reg < 4) { - hw_breakpoint_remove(env, reg); - env->dr[reg] = t0; - hw_breakpoint_insert(env, reg); + if (hw_breakpoint_enabled(env->dr[7], reg) + && hw_breakpoint_type(env->dr[7], reg) != DR7_TYPE_IO_RW) { + hw_breakpoint_remove(env, reg); + env->dr[reg] = t0; + hw_breakpoint_insert(env, reg); + } else { + env->dr[reg] = t0; + } } else if (reg == 7) { cpu_x86_update_dr7(env, t0); } else { -- 2.1.0