qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 3/9] block: Track discard requests
Date: Mon, 26 Oct 2015 14:24:47 +0800	[thread overview]
Message-ID: <1445840693-3177-4-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1445840693-3177-1-git-send-email-famz@redhat.com>

Both bdrv_discard and bdrv_aio_discard will call into bdrv_co_discard,
so add tracked_request_begin/end calls around the loop.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/io.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/block/io.c b/block/io.c
index 223c4e9..abb3aaa 100644
--- a/block/io.c
+++ b/block/io.c
@@ -2415,7 +2415,8 @@ static void coroutine_fn bdrv_discard_co_entry(void *opaque)
 int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num,
                                  int nb_sectors)
 {
-    int max_discard, ret;
+    BdrvTrackedRequest req;
+    int max_discard, ret = 0;
 
     if (!bs->drv) {
         return -ENOMEDIUM;
@@ -2437,6 +2438,8 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num,
         return 0;
     }
 
+    tracked_request_begin(&req, bs, sector_num, nb_sectors,
+                          BDRV_TRACKED_DISCARD);
     bdrv_set_dirty(bs, sector_num, nb_sectors);
 
     max_discard = MIN_NON_ZERO(bs->bl.max_discard, BDRV_REQUEST_MAX_SECTORS);
@@ -2470,20 +2473,23 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num,
             acb = bs->drv->bdrv_aio_discard(bs, sector_num, nb_sectors,
                                             bdrv_co_io_em_complete, &co);
             if (acb == NULL) {
-                return -EIO;
+                ret = -EIO;
+                goto out;
             } else {
                 qemu_coroutine_yield();
                 ret = co.ret;
             }
         }
         if (ret && ret != -ENOTSUP) {
-            return ret;
+            goto out;
         }
 
         sector_num += num;
         nb_sectors -= num;
     }
-    return 0;
+out:
+    tracked_request_end(&req);
+    return ret;
 }
 
 int bdrv_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors)
-- 
2.4.3

  parent reply	other threads:[~2015-10-26  6:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26  6:24 [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 1/9] block: Add more types for tracked request Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 2/9] block: Track flush requests Fam Zheng
2015-10-26  6:24 ` Fam Zheng [this message]
2015-10-28  9:54   ` [Qemu-devel] [PATCH 3/9] block: Track discard requests Kevin Wolf
2015-10-29  1:34     ` Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl Fam Zheng
2015-10-28  9:51   ` Kevin Wolf
2015-10-29  1:35     ` Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 5/9] block: Add ioctl parameter fields to BlockRequest Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 6/9] block: Emulate bdrv_ioctl with bdrv_aio_ioctl and track both Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 7/9] block: Drop BlockDriver.bdrv_ioctl Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 8/9] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-10-28 10:13   ` Kevin Wolf
2015-10-29  1:38     ` Fam Zheng
2015-10-26  6:24 ` [Qemu-devel] [PATCH 9/9] qed: Implement .bdrv_drain Fam Zheng
2015-10-28 10:16 ` [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445840693-3177-4-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).