From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqxS5-0003WR-MX for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqxS2-0000lR-F8 for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqxS2-0000lE-AB for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:42 -0400 From: Jason Wang Date: Tue, 27 Oct 2015 14:08:43 +0800 Message-Id: <1445926124-30681-10-git-send-email-jasowang@redhat.com> In-Reply-To: <1445926124-30681-1-git-send-email-jasowang@redhat.com> References: <1445926124-30681-1-git-send-email-jasowang@redhat.com> Subject: [Qemu-devel] [PULL 09/10] net: make iov_to_buf take right size argument in nc_sendv_compat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org, qemu-devel@nongnu.org Cc: Paolo Bonzini , Jason Wang , Yang Hongyang From: Yang Hongyang We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a pointer, which is wrong. Thanks to Paolo for pointing it out. Signed-off-by: Yang Hongyang Cc: Jason Wang Cc: Paolo Bonzini Signed-off-by: Jason Wang --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index 70a3576..2f2b39e 100644 --- a/net/net.c +++ b/net/net.c @@ -708,7 +708,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, offset = iov[0].iov_len; } else { buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer)); + offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { -- 2.1.4