From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqxRx-0003GT-Rg for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqxRw-0000kU-Rg for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqxRw-0000kM-Lm for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:36 -0400 From: Jason Wang Date: Tue, 27 Oct 2015 14:08:42 +0800 Message-Id: <1445926124-30681-9-git-send-email-jasowang@redhat.com> In-Reply-To: <1445926124-30681-1-git-send-email-jasowang@redhat.com> References: <1445926124-30681-1-git-send-email-jasowang@redhat.com> Subject: [Qemu-devel] [PULL 08/10] net: Remove duplicate data from query-rx-filter on multiqueue net devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org, qemu-devel@nongnu.org Cc: Vladislav Yasevich , Jason Wang From: Vladislav Yasevich When responding to a query-rx-filter command on a multiqueue netdev, qemu reports the data for each queue. The data, however, is not per-queue, but per device and the same data is reported multiple times. This causes confusion and may also cause extra unnecessary processing when looking at the data. Commit 638fb14169 (net: Make qmp_query_rx_filter() with name argument more obvious) partially addresses this issue, by limiting the output when the name is specified. However, when the name is not specified, the issue still persists. Signed-off-by: Vladislav Yasevich Signed-off-by: Jason Wang --- net/net.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/net.c b/net/net.c index 3c68f3f..70a3576 100644 --- a/net/net.c +++ b/net/net.c @@ -1227,6 +1227,12 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, continue; } + /* only query information on queue 0 since the info is per nic, + * not per queue + */ + if (nc->queue_index != 0) + continue; + if (nc->info->query_rx_filter) { info = nc->info->query_rx_filter(nc); entry = g_malloc0(sizeof(*entry)); -- 2.1.4