From: Yang Hongyang <hongyang.yang@easystack.cn>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Yang Hongyang <hongyang.yang@easystack.cn>
Subject: [Qemu-devel] [PATCH] vnc: fix bug: vnc server can't start when 'to' is specified
Date: Tue, 27 Oct 2015 14:10:52 +0800 [thread overview]
Message-ID: <1445926252-14830-1-git-send-email-hongyang.yang@easystack.cn> (raw)
commit e0d03b8ceb52 converted VNC startup to use SocketAddress,
the interface socket_listen don't have a port_offset param, so
we need to add the port offset (5900) to both 'port' and 'to' opts.
currently only 'port' is added by offset.
This patch add the port offset to 'to' opts.
Signed-off-by: Yang Hongyang <hongyang.yang@easystack.cn>
Cc: Daniel P. Berrange <berrange@redhat.com>
Cc: Eric Blake <eblake@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index faff054..db24545 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3545,7 +3545,7 @@ void vnc_display_open(const char *id, Error **errp)
if (to) {
saddr->inet->has_to = true;
- saddr->inet->to = to;
+ saddr->inet->to = to + 5900;
}
saddr->inet->ipv4 = saddr->inet->has_ipv4 = has_ipv4;
saddr->inet->ipv6 = saddr->inet->has_ipv6 = has_ipv6;
--
2.5.0
next reply other threads:[~2015-10-27 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 6:10 Yang Hongyang [this message]
2015-10-27 7:25 ` [Qemu-devel] [PATCH] vnc: fix bug: vnc server can't start when 'to' is specified Daniel P. Berrange
2015-10-28 14:43 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445926252-14830-1-git-send-email-hongyang.yang@easystack.cn \
--to=hongyang.yang@easystack.cn \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).