From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 4/6] virtio-serial: convert to virtio_map
Date: Tue, 27 Oct 2015 10:48:03 +0200 [thread overview]
Message-ID: <1445935663-31971-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1445935663-31971-1-git-send-email-mst@redhat.com>
This also fixes a minor bug:
- virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr,
- port->elem.out_num, 1);
is wrong: out_sg is not written so should not be marked dirty.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/char/virtio-serial-bus.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index be97058..497b0af 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -705,10 +705,7 @@ static int fetch_active_ports_list(QEMUFile *f, int version_id,
qemu_get_buffer(f, (unsigned char *)&port->elem,
sizeof(port->elem));
- virtqueue_map_sg(port->elem.in_sg, port->elem.in_addr,
- port->elem.in_num, 1);
- virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr,
- port->elem.out_num, 1);
+ virtqueue_map(&port->elem);
/*
* Port was throttled on source machine. Let's
--
MST
next prev parent reply other threads:[~2015-10-27 8:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 8:47 [Qemu-devel] [PATCH 0/6] virtio: handle non contigious s/g entries Michael S. Tsirkin
2015-10-27 8:47 ` [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map Michael S. Tsirkin
2015-10-27 16:13 ` Stefan Hajnoczi
2015-10-27 18:38 ` Michael S. Tsirkin
2015-10-27 16:19 ` Stefan Hajnoczi
2015-10-27 18:34 ` Michael S. Tsirkin
2015-10-28 11:37 ` Stefan Hajnoczi
2015-10-28 12:16 ` Igor Mammedov
2015-10-28 13:11 ` Igor Mammedov
2015-10-27 8:47 ` [Qemu-devel] [PATCH 2/6] virtio: switch to virtio_map Michael S. Tsirkin
2015-10-28 13:02 ` Igor Mammedov
2015-10-27 8:48 ` [Qemu-devel] [PATCH 3/6] virtio-blk: convert to virtqueue_map Michael S. Tsirkin
2015-10-28 13:02 ` Igor Mammedov
2015-10-27 8:48 ` Michael S. Tsirkin [this message]
2015-10-28 13:03 ` [Qemu-devel] [PATCH 4/6] virtio-serial: convert to virtio_map Igor Mammedov
2015-10-27 8:48 ` [Qemu-devel] [PATCH 5/6] virtio-scsi: convert to virtqueue_map Michael S. Tsirkin
2015-10-28 13:03 ` Igor Mammedov
2015-10-27 8:48 ` [Qemu-devel] [PATCH 6/6] virtio: drop virtqueue_map_sg Michael S. Tsirkin
2015-10-28 13:04 ` Igor Mammedov
2015-10-27 8:50 ` [Qemu-devel] [PATCH 0/6] virtio: handle non contigious s/g entries Michael S. Tsirkin
2015-10-27 11:51 ` Michael S. Tsirkin
2015-10-27 16:24 ` Stefan Hajnoczi
2015-10-28 12:30 ` Igor Mammedov
2015-10-27 12:06 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445935663-31971-5-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).