From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>, mst@redhat.com
Subject: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest
Date: Tue, 27 Oct 2015 17:29:43 +0100 [thread overview]
Message-ID: <1445963383-8345-1-git-send-email-marcandre.lureau@redhat.com> (raw)
From: Marc-André Lureau <marcandre.lureau@redhat.com>
vhost-user-test prints a warning. A test should not need to run on
hugetlbfs, let's silence the warning under qtest. Unfortunately, the
condition can't check on qtest_enabled() or qtest_driver() since they
are initialized later.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
exec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 8af2570..d9c231d 100644
--- a/exec.c
+++ b/exec.c
@@ -1194,8 +1194,9 @@ static long gethugepagesize(const char *path, Error **errp)
return 0;
}
- if (fs.f_type != HUGETLBFS_MAGIC)
+ if (fs.f_type != HUGETLBFS_MAGIC && !getenv("QTEST_QEMU_BINARY")) {
fprintf(stderr, "Warning: path not on HugeTLBFS: %s\n", path);
+ }
return fs.f_bsize;
}
--
2.4.3
next reply other threads:[~2015-10-27 16:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 16:29 marcandre.lureau [this message]
2015-10-27 18:37 ` [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest Michael S. Tsirkin
2015-10-29 9:10 ` Michael S. Tsirkin
2015-11-08 17:02 ` Michael S. Tsirkin
2015-11-09 7:50 ` Markus Armbruster
2015-11-12 11:54 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2015-11-16 17:23 [Qemu-devel] [PATCH 3/3] " marcandre.lureau
2015-11-18 9:02 ` [Qemu-devel] [PATCH] " marcandre.lureau
2015-11-18 20:49 ` Michael S. Tsirkin
2015-11-23 17:40 ` Paolo Bonzini
2015-11-23 17:46 ` Daniel P. Berrange
2015-11-23 17:49 ` Daniel P. Berrange
2015-11-23 18:01 ` Marc-André Lureau
2015-11-23 18:10 ` Daniel P. Berrange
2015-11-24 14:10 ` Michael S. Tsirkin
2015-11-24 14:19 ` Daniel P. Berrange
2015-11-24 14:25 ` Michael S. Tsirkin
2015-11-24 14:30 ` Daniel P. Berrange
2015-11-24 14:30 ` Paolo Bonzini
2015-11-24 15:29 ` Michael S. Tsirkin
2015-11-24 15:09 ` Markus Armbruster
2015-11-24 14:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445963383-8345-1-git-send-email-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).