From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrRVY-0008PM-NH for qemu-devel@nongnu.org; Wed, 28 Oct 2015 10:15:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrRVX-0006Wy-C3 for qemu-devel@nongnu.org; Wed, 28 Oct 2015 10:15:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrRVX-0006Wq-7H for qemu-devel@nongnu.org; Wed, 28 Oct 2015 10:15:19 -0400 From: Eduardo Habkost Date: Wed, 28 Oct 2015 12:15:08 -0200 Message-Id: <1446041709-26510-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1446041709-26510-1-git-send-email-ehabkost@redhat.com> References: <1446041709-26510-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 1/2] target-i386: Don't left shift negative constant List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson Left shift of negative values is undefined behavior. Detected by clang: qemu/target-i386/translate.c:2423:26: runtime error: left shift of negative value -8 This changes the code to reverse the sign after the left shift. Signed-off-by: Eduardo Habkost --- target-i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 764b1e4..862f8e0 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -2432,7 +2432,7 @@ static void gen_pusha(DisasContext *s) { int i; gen_op_movl_A0_reg(R_ESP); - gen_op_addl_A0_im(-8 << s->dflag); + gen_op_addl_A0_im(-(8 << s->dflag)); if (!s->ss32) tcg_gen_ext16u_tl(cpu_A0, cpu_A0); tcg_gen_mov_tl(cpu_T[1], cpu_A0); -- 2.1.0