From: "Denis V. Lunev" <den@openvz.org>
Cc: "Denis V. Lunev" <den@openvz.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH v3 0/4] dataplane snapshot fixes
Date: Wed, 28 Oct 2015 18:01:01 +0300 [thread overview]
Message-ID: <1446044465-19312-1-git-send-email-den@openvz.org> (raw)
with test
while /bin/true ; do
virsh snapshot-create rhel7
sleep 10
virsh snapshot-delete rhel7 --current
done
with enabled iothreads on a running VM leads to a lot of troubles: hangs,
asserts, errors.
Anyway, I think that the construction like
assert(aio_context_is_locked(aio_context));
should be widely used to ensure proper locking.
Changes from v2:
- droppped patch 5 as already merged
- changed locking scheme in patch 4 by suggestion of Juan
Changes from v1:
- aio-context locking added
- comment is rewritten
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
fifolock: create rfifolock_is_locked helper
aio_context: create aio_context_is_locked helper
io: add locking constraints check into bdrv_drain to ensure locking
migration: add missed aio_context_acquire into hmp_savevm/hmp_delvm
async.c | 5 +++++
block/io.c | 5 ++++-
block/snapshot.c | 5 +++++
include/block/aio.h | 3 +++
include/qemu/rfifolock.h | 1 +
migration/savevm.c | 18 +++++++++++++++---
util/rfifolock.c | 9 +++++++--
7 files changed, 40 insertions(+), 6 deletions(-)
--
2.1.4
next reply other threads:[~2015-10-28 15:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 15:01 Denis V. Lunev [this message]
2015-10-28 15:01 ` [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper Denis V. Lunev
2015-10-30 15:41 ` Stefan Hajnoczi
2015-10-30 20:30 ` Denis V. Lunev
2015-11-02 13:10 ` Stefan Hajnoczi
2015-11-01 13:55 ` Denis V. Lunev
2015-11-02 13:12 ` Stefan Hajnoczi
2015-11-02 13:39 ` Denis V. Lunev
2015-11-02 13:55 ` Paolo Bonzini
2015-11-02 14:02 ` Denis V. Lunev
2015-10-28 15:01 ` [Qemu-devel] [PATCH 2/4] aio_context: create aio_context_is_locked helper Denis V. Lunev
2015-10-30 15:42 ` Stefan Hajnoczi
2015-10-28 15:01 ` [Qemu-devel] [PATCH 3/4] io: add locking constraints check into bdrv_drain to ensure locking Denis V. Lunev
2015-10-30 15:43 ` Stefan Hajnoczi
2015-10-28 15:01 ` [Qemu-devel] [PATCH 4/4] migration: add missed aio_context_acquire into HMP snapshot code Denis V. Lunev
2015-10-28 15:33 ` Juan Quintela
2015-10-28 15:57 ` Denis V. Lunev
2015-10-30 15:52 ` Stefan Hajnoczi
2015-11-03 14:48 ` Juan Quintela
2015-11-03 15:30 ` Stefan Hajnoczi
2015-11-03 15:36 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446044465-19312-1-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).