qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Jones <drjones@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v2 11/16] vl.c: Remove unnecessary uppercase in error messages
Date: Wed, 28 Oct 2015 16:37:00 -0200	[thread overview]
Message-ID: <1446057425-16891-12-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1446057425-16891-1-git-send-email-ehabkost@redhat.com>

Suggested-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 vl.c | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

diff --git a/vl.c b/vl.c
index b8c6c3c..cd76ff4 100644
--- a/vl.c
+++ b/vl.c
@@ -905,7 +905,7 @@ static int bt_hci_parse(const char *str)
     bdaddr_t bdaddr;
 
     if (nb_hcis >= MAX_NICS) {
-        error_report("Too many bluetooth HCIs (max %i)", MAX_NICS);
+        error_report("too many bluetooth HCIs (max %i)", MAX_NICS);
         return -1;
     }
 
@@ -1099,7 +1099,7 @@ static int parse_add_fd(void *opaque, QemuOpts *opts, Error **errp)
     }
 #endif
     if (dupfd == -1) {
-        error_report("Error duplicating fd: %s", strerror(errno));
+        error_report("error duplicating fd: %s", strerror(errno));
         return -1;
     }
 
@@ -1246,7 +1246,7 @@ static void smp_parse(QemuOpts *opts)
     }
 
     if (max_cpus > MAX_CPUMASK_BITS) {
-        error_report("Unsupported number of maxcpus");
+        error_report("unsupported number of maxcpus");
         exit(1);
     }
     if (max_cpus < smp_cpus) {
@@ -2029,7 +2029,7 @@ static void select_vgahw (const char *p)
         }
     } else if (!strstart(p, "none", &opts)) {
     invalid_vga:
-        error_report("Unknown vga type: %s", p);
+        error_report("unknown vga type: %s", p);
         exit(1);
     }
     while (*opts) {
@@ -2105,7 +2105,7 @@ static DisplayType select_display(const char *p)
                 }
             } else {
             invalid_sdl_args:
-                error_report("Invalid SDL option string");
+                error_report("invalid SDL option string");
                 exit(1);
             }
             opts = nextopt;
@@ -2163,7 +2163,7 @@ static DisplayType select_display(const char *p)
                 }
             } else {
             invalid_gtk_args:
-                error_report("Invalid GTK option string");
+                error_report("invalid GTK option string");
                 exit(1);
             }
             opts = nextopt;
@@ -2175,7 +2175,7 @@ static DisplayType select_display(const char *p)
     } else if (strstart(p, "none", &opts)) {
         display = DT_NONE;
     } else {
-        error_report("Unknown display type");
+        error_report("unknown display type");
         exit(1);
     }
 
@@ -3548,7 +3548,7 @@ int main(int argc, char **argv, char **envp)
                 break;
             case QEMU_OPTION_watchdog_action:
                 if (select_watchdog_action(optarg) == -1) {
-                    error_report("Unknown -watchdog-action parameter");
+                    error_report("unknown -watchdog-action parameter");
                     exit(1);
                 }
                 break;
@@ -3716,7 +3716,7 @@ int main(int argc, char **argv, char **envp)
                 break;
             case QEMU_OPTION_balloon:
                 if (balloon_parse(optarg) < 0) {
-                    error_report("Unknown -balloon argument %s", optarg);
+                    error_report("unknown -balloon argument %s", optarg);
                     exit(1);
                 }
                 break;
@@ -3731,15 +3731,14 @@ int main(int argc, char **argv, char **envp)
                 break;
             case QEMU_OPTION_uuid:
                 if(qemu_uuid_parse(optarg, qemu_uuid) < 0) {
-                    error_report("Fail to parse UUID string."
-                                 " Wrong format");
+                    error_report("failed to parse UUID string: wrong format");
                     exit(1);
                 }
                 qemu_uuid_set = true;
                 break;
             case QEMU_OPTION_option_rom:
                 if (nb_option_roms >= MAX_OPTION_ROMS) {
-                    error_report("Too many option ROMs");
+                    error_report("too many option ROMs");
                     exit(1);
                 }
                 opts = qemu_opts_parse_noisily(qemu_find_opts("option-rom"),
@@ -3776,7 +3775,7 @@ int main(int argc, char **argv, char **envp)
                         } else  if (strcmp("auto", target) == 0) {
                             semihosting.target = SEMIHOSTING_TARGET_AUTO;
                         } else {
-                            error_report("Unsupported semihosting-config %s",
+                            error_report("unsupported semihosting-config %s",
                                          optarg);
                             exit(1);
                         }
@@ -3787,8 +3786,7 @@ int main(int argc, char **argv, char **envp)
                     qemu_opt_foreach(opts, add_semihosting_arg,
                                      &semihosting, NULL);
                 } else {
-                    error_report("Unsupported semihosting-config %s",
-                                 optarg);
+                    error_report("unsupported semihosting-config %s", optarg);
                     exit(1);
                 }
                 break;
@@ -3804,7 +3802,7 @@ int main(int argc, char **argv, char **envp)
                 break;
             case QEMU_OPTION_prom_env:
                 if (nb_prom_envs >= MAX_PROM_ENVS) {
-                    error_report("Too many prom variables");
+                    error_report("too many prom variables");
                     exit(1);
                 }
                 prom_envs[nb_prom_envs] = optarg;
@@ -4273,7 +4271,7 @@ int main(int argc, char **argv, char **envp)
 #endif
 
     if (pid_file && qemu_create_pidfile(pid_file) != 0) {
-        error_report("Could not acquire pid file: %s", strerror(errno));
+        error_report("could not acquire pid file: %s", strerror(errno));
         exit(1);
     }
 
-- 
2.1.0

  parent reply	other threads:[~2015-10-28 18:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 18:36 [Qemu-devel] [PATCH v2 00/16] vl.c: Error message rework Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 01/16] vl.c: Replace fprintf(stderr) with error_report() Eduardo Habkost
2015-10-29 17:34   ` Markus Armbruster
2015-10-29 17:52     ` Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 02/16] vl.c: Use error_report() when reporting shutdown signal Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 03/16] vl.c: Remove periods from error_report() error messages Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 04/16] vl.c: Use "warning:" prefix consistently on warnings Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 05/16] vl.c: Use "cannot" instead of "can not" in error messages Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 06/16] vl.c: Use 'quotes' instead of `quotes' in messages Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 07/16] vl.c: Use "%s support disabled" error messages consistently Eduardo Habkost
2015-10-29 16:59   ` Markus Armbruster
2015-10-30 13:28     ` Andrew Jones
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 08/16] vl.c: Simplify "ignoring deprecated option" warnings Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection deprecation warning Eduardo Habkost
2015-10-29 17:10   ` Markus Armbruster
2015-10-30 13:33     ` Andrew Jones
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 10/16] vl.c: Convert error sentences to simpler phrases Eduardo Habkost
2015-10-29 17:25   ` Markus Armbruster
2015-10-28 18:37 ` Eduardo Habkost [this message]
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 12/16] vl.c: trivial: Don't wrap lines unnecessarily Eduardo Habkost
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 13/16] vl.c: Reword -machine help error messages Eduardo Habkost
2015-10-29 17:27   ` Markus Armbruster
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 14/16] vl.c: Simplify date format error message Eduardo Habkost
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 15/16] vl.c: Use US spelling for "unrecognized" Eduardo Habkost
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 16/16] vl.c: Reword fw_cfg name prefix warning Eduardo Habkost
2015-10-29 17:34   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446057425-16891-12-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=drjones@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).