From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v2 03/16] vl.c: Remove periods from error_report() error messages
Date: Wed, 28 Oct 2015 16:36:52 -0200 [thread overview]
Message-ID: <1446057425-16891-4-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1446057425-16891-1-git-send-email-ehabkost@redhat.com>
Except for removing periods, no other changes were made to the error
messages (yet).
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
vl.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/vl.c b/vl.c
index 71104ae..e744c75 100644
--- a/vl.c
+++ b/vl.c
@@ -905,7 +905,7 @@ static int bt_hci_parse(const char *str)
bdaddr_t bdaddr;
if (nb_hcis >= MAX_NICS) {
- error_report("Too many bluetooth HCIs (max %i).", MAX_NICS);
+ error_report("Too many bluetooth HCIs (max %i)", MAX_NICS);
return -1;
}
@@ -3440,7 +3440,7 @@ int main(int argc, char **argv, char **envp)
case QEMU_OPTION_fsdev:
olist = qemu_find_opts("fsdev");
if (!olist) {
- error_report("fsdev is not supported by this qemu build.");
+ error_report("fsdev is not supported by this qemu build");
exit(1);
}
opts = qemu_opts_parse_noisily(olist, optarg, true);
@@ -3455,7 +3455,7 @@ int main(int argc, char **argv, char **envp)
olist = qemu_find_opts("virtfs");
if (!olist) {
- error_report("virtfs is not supported by this qemu build.");
+ error_report("virtfs is not supported by this qemu build");
exit(1);
}
opts = qemu_opts_parse_noisily(olist, optarg, true);
@@ -3465,7 +3465,7 @@ int main(int argc, char **argv, char **envp)
if (qemu_opt_get(opts, "fsdriver") == NULL ||
qemu_opt_get(opts, "mount_tag") == NULL) {
- error_report("Usage: -virtfs fsdriver,mount_tag=tag.");
+ error_report("Usage: -virtfs fsdriver,mount_tag=tag");
exit(1);
}
fsdev = qemu_opts_create(qemu_find_opts("fsdev"),
@@ -3656,7 +3656,7 @@ int main(int argc, char **argv, char **envp)
break;
case QEMU_OPTION_no_kvm_pit: {
error_report("Warning: KVM PIT can no longer be disabled "
- "separately.");
+ "separately");
break;
}
case QEMU_OPTION_no_kvm_pit_reinjection: {
@@ -3670,7 +3670,7 @@ int main(int argc, char **argv, char **envp)
};
error_report("Warning: option deprecated, use "
- "lost_tick_policy property of kvm-pit instead.");
+ "lost_tick_policy property of kvm-pit instead");
qdev_prop_register_global_list(kvm_pit_lost_tick_policy);
break;
}
@@ -3734,7 +3734,7 @@ int main(int argc, char **argv, char **envp)
case QEMU_OPTION_uuid:
if(qemu_uuid_parse(optarg, qemu_uuid) < 0) {
error_report("Fail to parse UUID string."
- " Wrong format.");
+ " Wrong format");
exit(1);
}
qemu_uuid_set = true;
@@ -3796,7 +3796,7 @@ int main(int argc, char **argv, char **envp)
break;
case QEMU_OPTION_tdf:
error_report("Warning: user space PIT time drift fix "
- "is no longer supported.");
+ "is no longer supported");
break;
case QEMU_OPTION_name:
opts = qemu_opts_parse_noisily(qemu_find_opts("name"),
@@ -3899,7 +3899,7 @@ int main(int argc, char **argv, char **envp)
case QEMU_OPTION_spice:
olist = qemu_find_opts("spice");
if (!olist) {
- error_report("spice is not supported by this qemu build.");
+ error_report("spice is not supported by this qemu build");
exit(1);
}
opts = qemu_opts_parse_noisily(olist, optarg, false);
@@ -4249,9 +4249,9 @@ int main(int argc, char **argv, char **envp)
#endif
if (request_opengl == 1 && display_opengl == 0) {
#if defined(CONFIG_OPENGL)
- error_report("OpenGL is not supported by the display.");
+ error_report("OpenGL is not supported by the display");
#else
- error_report("QEMU was built without opengl support.");
+ error_report("QEMU was built without opengl support");
#endif
exit(1);
}
--
2.1.0
next prev parent reply other threads:[~2015-10-28 18:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 18:36 [Qemu-devel] [PATCH v2 00/16] vl.c: Error message rework Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 01/16] vl.c: Replace fprintf(stderr) with error_report() Eduardo Habkost
2015-10-29 17:34 ` Markus Armbruster
2015-10-29 17:52 ` Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 02/16] vl.c: Use error_report() when reporting shutdown signal Eduardo Habkost
2015-10-28 18:36 ` Eduardo Habkost [this message]
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 04/16] vl.c: Use "warning:" prefix consistently on warnings Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 05/16] vl.c: Use "cannot" instead of "can not" in error messages Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 06/16] vl.c: Use 'quotes' instead of `quotes' in messages Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 07/16] vl.c: Use "%s support disabled" error messages consistently Eduardo Habkost
2015-10-29 16:59 ` Markus Armbruster
2015-10-30 13:28 ` Andrew Jones
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 08/16] vl.c: Simplify "ignoring deprecated option" warnings Eduardo Habkost
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection deprecation warning Eduardo Habkost
2015-10-29 17:10 ` Markus Armbruster
2015-10-30 13:33 ` Andrew Jones
2015-10-28 18:36 ` [Qemu-devel] [PATCH v2 10/16] vl.c: Convert error sentences to simpler phrases Eduardo Habkost
2015-10-29 17:25 ` Markus Armbruster
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 11/16] vl.c: Remove unnecessary uppercase in error messages Eduardo Habkost
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 12/16] vl.c: trivial: Don't wrap lines unnecessarily Eduardo Habkost
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 13/16] vl.c: Reword -machine help error messages Eduardo Habkost
2015-10-29 17:27 ` Markus Armbruster
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 14/16] vl.c: Simplify date format error message Eduardo Habkost
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 15/16] vl.c: Use US spelling for "unrecognized" Eduardo Habkost
2015-10-28 18:37 ` [Qemu-devel] [PATCH v2 16/16] vl.c: Reword fw_cfg name prefix warning Eduardo Habkost
2015-10-29 17:34 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446057425-16891-4-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).