qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] fixup! dataplane: support non-contigious s/g
@ 2015-10-28 21:18 Michael S. Tsirkin
  2015-11-02 17:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
  0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-10-28 21:18 UTC (permalink / raw)
  To: qemu-devel; +Cc: Igor Mammedov, qemu-block, Stefan Hajnoczi

Should fix issues Stefan reported.

---

Built only.

 hw/virtio/dataplane/vring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c
index 9ae9424..23f667e 100644
--- a/hw/virtio/dataplane/vring.c
+++ b/hw/virtio/dataplane/vring.c
@@ -261,8 +261,8 @@ static int get_desc(Vring *vring, VirtQueueElement *elem,
 
         /* The MemoryRegion is looked up again and unref'ed later, leave the
          * ref in place.  */
-        iov->iov_len = len;
-        *addr = desc->addr;
+        (iov++)->iov_len = len;
+        *addr++ = desc->addr;
         desc->len -= len;
         desc->addr += len;
         *num += 1;
-- 
MST

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [Qemu-block] [PATCH] fixup! dataplane: support non-contigious s/g
  2015-10-28 21:18 [Qemu-devel] [PATCH] fixup! dataplane: support non-contigious s/g Michael S. Tsirkin
@ 2015-11-02 17:41 ` Stefan Hajnoczi
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2015-11-02 17:41 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: Igor Mammedov, Stefan Hajnoczi, qemu-devel, qemu-block

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

On Wed, Oct 28, 2015 at 11:18:42PM +0200, Michael S. Tsirkin wrote:
> Should fix issues Stefan reported.
> 
> ---
> 
> Built only.
> 
>  hw/virtio/dataplane/vring.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Squashed in to the previous commit.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-02 17:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-28 21:18 [Qemu-devel] [PATCH] fixup! dataplane: support non-contigious s/g Michael S. Tsirkin
2015-11-02 17:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).