From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v5 26/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method
Date: Wed, 28 Oct 2015 22:26:24 +0000 [thread overview]
Message-ID: <1446071191-62591-27-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1446071191-62591-1-git-send-email-guangrong.xiao@linux.intel.com>
Check if the input Arg3 is valid then store it into dsm_in if needed
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
hw/acpi/nvdimm.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 8412be3..69de4f6 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -524,13 +524,38 @@ static void nvdimm_build_acpi_devices(GSList *device_list, Aml *sb_scope)
method = aml_method_serialized("NCAL", 4);
{
- Aml *buffer_size = aml_local(0);
+ Aml *ifctx, *pckg, *buffer_size = aml_local(0);
aml_append(method, aml_store(aml_arg(0), aml_name("HDLE")));
aml_append(method, aml_store(aml_arg(1), aml_name("REVS")));
aml_append(method, aml_store(aml_arg(2), aml_name("FUNC")));
/*
+ * The fourth parameter (Arg3) of _DSM is a package which contains
+ * a buffer, the layout of the buffer is specified by UUID (Arg0),
+ * Revision ID (Arg1) and Function Index (Arg2) which are documented
+ * in the DSM Spec.
+ */
+ pckg = aml_arg(3);
+ ifctx = aml_if(aml_and(aml_equal(aml_object_type(pckg),
+ aml_int(4 /* Package */)),
+ aml_equal(aml_sizeof(pckg),
+ aml_int(1))));
+ {
+ Aml *pckg_index, *pckg_buf;
+
+ pckg_index = aml_local(2);
+ pckg_buf = aml_local(3);
+
+ aml_append(ifctx, aml_store(aml_index(pckg, aml_int(0)),
+ pckg_index));
+ aml_append(ifctx, aml_store(aml_derefof(pckg_index),
+ pckg_buf));
+ aml_append(ifctx, aml_store(pckg_buf, aml_name("ARG3")));
+ }
+ aml_append(method, ifctx);
+
+ /*
* transfer control to QEMU and the buffer size filled by
* QEMU is returned.
*/
--
1.8.3.1
next prev parent reply other threads:[~2015-10-28 14:32 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 22:25 [Qemu-devel] [PATCH v5 00/33] implement vNVDIMM Xiao Guangrong
2015-10-28 22:25 ` [Qemu-devel] [PATCH v5 01/33] acpi: add aml_derefof Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 02/33] acpi: add aml_sizeof Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 03/33] acpi: add aml_create_field Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 04/33] acpi: add aml_concatenate Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 05/33] acpi: add aml_object_type Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 06/33] acpi: add aml_method_serialized Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 07/33] util: introduce qemu_file_get_page_size() Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 08/33] exec: allow memory to be allocated from any kind of path Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 09/33] exec: allow file_ram_alloc to work on file Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 10/33] hostmem-file: clean up memory allocation Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 11/33] hostmem-file: use whole file size if possible Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 12/33] pc-dimm: remove DEFAULT_PC_DIMMSIZE Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 13/33] pc-dimm: make pc_existing_dimms_capacity static and rename it Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 14/33] pc-dimm: drop the prefix of pc-dimm Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 15/33] stubs: rename qmp_pc_dimm_device_list.c Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 16/33] pc-dimm: rename pc-dimm.c and pc-dimm.h Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 17/33] dimm: abstract dimm device from pc-dimm Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 18/33] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 19/33] dimm: keep the state of the whole backend memory Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 20/33] dimm: introduce realize callback Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 21/33] nvdimm: implement NVDIMM device abstract Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 22/33] docs: add NVDIMM ACPI documentation Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 23/33] nvdimm acpi: init the resource used by NVDIMM ACPI Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 24/33] nvdimm acpi: build ACPI NFIT table Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 25/33] nvdimm acpi: build ACPI nvdimm devices Xiao Guangrong
2015-10-28 22:26 ` Xiao Guangrong [this message]
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 27/33] nvdimm acpi: support function 0 Xiao Guangrong
2015-10-28 16:37 ` Stefan Hajnoczi
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 28/33] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2015-10-28 16:41 ` Stefan Hajnoczi
2015-10-29 2:16 ` Xiao Guangrong
2015-10-29 14:14 ` Stefan Hajnoczi
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 29/33] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong
2015-10-28 16:46 ` Stefan Hajnoczi
2015-10-29 2:25 ` Xiao Guangrong
2015-10-29 2:58 ` Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 30/33] nvdimm acpi: support Set " Xiao Guangrong
2015-10-28 16:48 ` Stefan Hajnoczi
2015-10-29 2:26 ` Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 31/33] nvdimm: allow using whole backend memory as pmem Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 32/33] nvdimm acpi: support _FIT method Xiao Guangrong
2015-10-28 22:26 ` [Qemu-devel] [PATCH v5 33/33] nvdimm: add maintain info Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446071191-62591-27-git-send-email-guangrong.xiao@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).