From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 2/9] block: Track flush requests
Date: Thu, 29 Oct 2015 10:14:19 +0800 [thread overview]
Message-ID: <1446084866-12451-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1446084866-12451-1-git-send-email-famz@redhat.com>
Both bdrv_flush and bdrv_aio_flush eventually call bdrv_co_flush, add
tracked_request_begin and tracked_request_end pair in that function so
that all flush requests are now tracked.
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
block/io.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/block/io.c b/block/io.c
index 6af26c3..5c1f093 100644
--- a/block/io.c
+++ b/block/io.c
@@ -2315,18 +2315,20 @@ static void coroutine_fn bdrv_flush_co_entry(void *opaque)
int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
{
int ret;
+ BdrvTrackedRequest req;
if (!bs || !bdrv_is_inserted(bs) || bdrv_is_read_only(bs) ||
bdrv_is_sg(bs)) {
return 0;
}
+ tracked_request_begin(&req, bs, 0, 0, BDRV_TRACKED_FLUSH);
/* Write back cached data to the OS even with cache=unsafe */
BLKDBG_EVENT(bs->file, BLKDBG_FLUSH_TO_OS);
if (bs->drv->bdrv_co_flush_to_os) {
ret = bs->drv->bdrv_co_flush_to_os(bs);
if (ret < 0) {
- return ret;
+ goto out;
}
}
@@ -2366,14 +2368,17 @@ int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
ret = 0;
}
if (ret < 0) {
- return ret;
+ goto out;
}
/* Now flush the underlying protocol. It will also have BDRV_O_NO_FLUSH
* in the case of cache=unsafe, so there are no useless flushes.
*/
flush_parent:
- return bs->file ? bdrv_co_flush(bs->file->bs) : 0;
+ ret = bs->file ? bdrv_co_flush(bs->file->bs) : 0;
+out:
+ tracked_request_end(&req);
+ return ret;
}
int bdrv_flush(BlockDriverState *bs)
--
2.4.3
next prev parent reply other threads:[~2015-10-29 2:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 2:14 [Qemu-devel] [PATCH v2 0/9] block: Fixes for bdrv_drain Fam Zheng
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 1/9] block: Add more types for tracked request Fam Zheng
2015-10-29 2:14 ` Fam Zheng [this message]
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 3/9] block: Track discard requests Fam Zheng
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl Fam Zheng
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 5/9] block: Add ioctl parameter fields to BlockRequest Fam Zheng
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 6/9] block: Emulate bdrv_ioctl with bdrv_aio_ioctl and track both Fam Zheng
2015-11-05 15:59 ` Stefan Hajnoczi
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 7/9] block: Drop BlockDriver.bdrv_ioctl Fam Zheng
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 8/9] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-11-05 16:35 ` Stefan Hajnoczi
2015-11-05 17:11 ` Paolo Bonzini
2015-10-29 2:14 ` [Qemu-devel] [PATCH v2 9/9] qed: Implement .bdrv_drain Fam Zheng
2015-11-03 12:19 ` [Qemu-devel] [PATCH v2 0/9] block: Fixes for bdrv_drain Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446084866-12451-3-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).