[Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Leonid Bloch]

This series addresses two cases where errors were printed if whitespaces
appeared in front of a square bracket in places where there should be no
problem with such placements (please see messages of individual commits).

Leonid Bloch (2):
  checkpatch: Eliminate false positive in case of comma-space-square
    bracket
  checkpatch: Eliminate false positive in case of space before square
    bracket in a definition

 scripts/checkpatch.pl | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
2.4.3

[Qemu-devel] [PATCH 1/2] checkpatch: Eliminate false positive in case of comma-space-square bracket

[Leonid Bloch]

Previously, an error was printed in cases such as:
{ [1] = 5, [2] = 6 }
The space passed OK after a curly brace, but not after a comma.
Now, a space before a square bracket is allowed, if a comma comes before
it.

Signed-off-by: Leonid Bloch <leonid@daynix.com>
---
 scripts/checkpatch.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b0f6e11..455d94b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1715,11 +1715,13 @@ sub process {
 #  1. with a type on the left -- int [] a;
 #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
 #  3. inside a curly brace -- = { [0...10] = 5 }
+#  4. after a comma -- [1] = 5, [2] = 6
 		while ($line =~ /(.*?\s)\[/g) {
 			my ($where, $prefix) = ($-[1], $1);
 			if ($prefix !~ /$Type\s+$/ &&
 			    ($where != 0 || $prefix !~ /^.\s+$/) &&
-			    $prefix !~ /{\s+$/) {
+			    $prefix !~ /{\s+$/ &&
+			    $prefix !~ /,\s+$/) {
 				ERROR("space prohibited before open square bracket '['\n" . $herecurr);
 			}
 		}
-- 
2.4.3

[Qemu-devel] [PATCH 2/2] checkpatch: Eliminate false positive in case of space before square bracket in a definition

[Leonid Bloch]

Now, macro definition such as "#define abc(x) [x] = y" should pass
without an error.

Signed-off-by: Leonid Bloch <leonid@daynix.com>
---
 scripts/checkpatch.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 455d94b..e7d9cce 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1716,11 +1716,13 @@ sub process {
 #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
 #  3. inside a curly brace -- = { [0...10] = 5 }
 #  4. after a comma -- [1] = 5, [2] = 6
+#  5. in a macro definition -- #define abc(x) [x] = y
 		while ($line =~ /(.*?\s)\[/g) {
 			my ($where, $prefix) = ($-[1], $1);
 			if ($prefix !~ /$Type\s+$/ &&
 			    ($where != 0 || $prefix !~ /^.\s+$/) &&
 			    $prefix !~ /{\s+$/ &&
+			    $prefix !~ /\#\s*define[^(]*\([^)]*\)\s+$/ &&
 			    $prefix !~ /,\s+$/) {
 				ERROR("space prohibited before open square bracket '['\n" . $herecurr);
 			}
-- 
2.4.3

Re: [Qemu-devel] [PATCH 2/2] checkpatch: Eliminate false positive in case of space before square bracket in a definition

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

On 10/29/2015 03:48 AM, Leonid Bloch wrote:
> Now, macro definition such as "#define abc(x) [x] = y" should pass
> without an error.

Do we even have macros like that? Without context, it seems like that
macro definition is under-parenthesized, and that you wouldn't want to
use abc(x) in an arbitrary expression for fear of precedence rules
causing nasty surprises.

> 
> Signed-off-by: Leonid Bloch <leonid@daynix.com>
> ---
>  scripts/checkpatch.pl | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 455d94b..e7d9cce 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1716,11 +1716,13 @@ sub process {
>  #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
>  #  3. inside a curly brace -- = { [0...10] = 5 }
>  #  4. after a comma -- [1] = 5, [2] = 6
> +#  5. in a macro definition -- #define abc(x) [x] = y
>  		while ($line =~ /(.*?\s)\[/g) {
>  			my ($where, $prefix) = ($-[1], $1);
>  			if ($prefix !~ /$Type\s+$/ &&
>  			    ($where != 0 || $prefix !~ /^.\s+$/) &&
>  			    $prefix !~ /{\s+$/ &&
> +			    $prefix !~ /\#\s*define[^(]*\([^)]*\)\s+$/ &&
>  			    $prefix !~ /,\s+$/) {
>  				ERROR("space prohibited before open square bracket '['\n" . $herecurr);
>  			}
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH 2/2] checkpatch: Eliminate false positive in case of space before square bracket in a definition

[Leonid Bloch]

On Thu, Oct 29, 2015 at 6:13 PM, Eric Blake <eblake@redhat.com> wrote:
>
> On 10/29/2015 03:48 AM, Leonid Bloch wrote:
> > Now, macro definition such as "#define abc(x) [x] = y" should pass
> > without an error.
>
> Do we even have macros like that? Without context, it seems like that
> macro definition is under-parenthesized, and that you wouldn't want to
> use abc(x) in an arbitrary expression for fear of precedence rules
> causing nasty surprises.

Yes, for example, in hw/net/e1000.c, there is:
#define getreg(x)    [x] = mac_readreg  (l: 1209)
#define putreg(x)    [x] = mac_writereg  (l: 1230)

This issue came up in the latest patches I've sent to e1000, and in
the RFC patches we have sent for e1000e.

Leonid.
>
> >
> > Signed-off-by: Leonid Bloch <leonid@daynix.com>
> > ---
> >  scripts/checkpatch.pl | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 455d94b..e7d9cce 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1716,11 +1716,13 @@ sub process {
> >  #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
> >  #  3. inside a curly brace -- = { [0...10] = 5 }
> >  #  4. after a comma -- [1] = 5, [2] = 6
> > +#  5. in a macro definition -- #define abc(x) [x] = y
> >               while ($line =~ /(.*?\s)\[/g) {
> >                       my ($where, $prefix) = ($-[1], $1);
> >                       if ($prefix !~ /$Type\s+$/ &&
> >                           ($where != 0 || $prefix !~ /^.\s+$/) &&
> >                           $prefix !~ /{\s+$/ &&
> > +                         $prefix !~ /\#\s*define[^(]*\([^)]*\)\s+$/ &&
> >                           $prefix !~ /,\s+$/) {
> >                               ERROR("space prohibited before open square bracket '['\n" . $herecurr);
> >                       }
> >
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Leonid Bloch]

ping

http://patchwork.ozlabs.org/patch/537763
http://patchwork.ozlabs.org/patch/537762

On Thu, Oct 29, 2015 at 11:48 AM, Leonid Bloch <leonid@daynix.com> wrote:
> This series addresses two cases where errors were printed if whitespaces
> appeared in front of a square bracket in places where there should be no
> problem with such placements (please see messages of individual commits).
>
> Leonid Bloch (2):
>   checkpatch: Eliminate false positive in case of comma-space-square
>     bracket
>   checkpatch: Eliminate false positive in case of space before square
>     bracket in a definition
>
>  scripts/checkpatch.pl | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.4.3
>

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Leonid Bloch]

ping

http://patchwork.ozlabs.org/patch/537763
http://patchwork.ozlabs.org/patch/537762

On Tue, Nov 10, 2015 at 11:48 AM, Leonid Bloch <leonid@daynix.com> wrote:
> ping
>
> http://patchwork.ozlabs.org/patch/537763
> http://patchwork.ozlabs.org/patch/537762
>
> On Thu, Oct 29, 2015 at 11:48 AM, Leonid Bloch <leonid@daynix.com> wrote:
>> This series addresses two cases where errors were printed if whitespaces
>> appeared in front of a square bracket in places where there should be no
>> problem with such placements (please see messages of individual commits).
>>
>> Leonid Bloch (2):
>>   checkpatch: Eliminate false positive in case of comma-space-square
>>     bracket
>>   checkpatch: Eliminate false positive in case of space before square
>>     bracket in a definition
>>
>>  scripts/checkpatch.pl | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> --
>> 2.4.3
>>

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Leonid Bloch]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

ping

http://patchwork.ozlabs.org/patch/537763
http://patchwork.ozlabs.org/patch/537762

On Tue, Nov 24, 2015 at 4:43 PM, Leonid Bloch <leonid@daynix.com> wrote:

> ping
>
> http://patchwork.ozlabs.org/patch/537763
> http://patchwork.ozlabs.org/patch/537762
>
> On Tue, Nov 10, 2015 at 11:48 AM, Leonid Bloch <leonid@daynix.com> wrote:
> > ping
> >
> > http://patchwork.ozlabs.org/patch/537763
> > http://patchwork.ozlabs.org/patch/537762
> >
> > On Thu, Oct 29, 2015 at 11:48 AM, Leonid Bloch <leonid@daynix.com>
> wrote:
> >> This series addresses two cases where errors were printed if whitespaces
> >> appeared in front of a square bracket in places where there should be no
> >> problem with such placements (please see messages of individual
> commits).
> >>
> >> Leonid Bloch (2):
> >>   checkpatch: Eliminate false positive in case of comma-space-square
> >>     bracket
> >>   checkpatch: Eliminate false positive in case of space before square
> >>     bracket in a definition
> >>
> >>  scripts/checkpatch.pl | 6 +++++-
> >>  1 file changed, 5 insertions(+), 1 deletion(-)
> >>
> >> --
> >> 2.4.3
> >>
>

[-- Attachment #2: Type: text/html, Size: 2321 bytes --]

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Leonid Bloch]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

ping

On Sun, Dec 20, 2015 at 11:31 AM, Leonid Bloch <leonid@daynix.com> wrote:

> ping
>
> http://patchwork.ozlabs.org/patch/537763
> http://patchwork.ozlabs.org/patch/537762
>
> On Tue, Nov 24, 2015 at 4:43 PM, Leonid Bloch <leonid@daynix.com> wrote:
>
>> ping
>>
>> http://patchwork.ozlabs.org/patch/537763
>> http://patchwork.ozlabs.org/patch/537762
>>
>> On Tue, Nov 10, 2015 at 11:48 AM, Leonid Bloch <leonid@daynix.com> wrote:
>> > ping
>> >
>> > http://patchwork.ozlabs.org/patch/537763
>> > http://patchwork.ozlabs.org/patch/537762
>> >
>> > On Thu, Oct 29, 2015 at 11:48 AM, Leonid Bloch <leonid@daynix.com>
>> wrote:
>> >> This series addresses two cases where errors were printed if
>> whitespaces
>> >> appeared in front of a square bracket in places where there should be
>> no
>> >> problem with such placements (please see messages of individual
>> commits).
>> >>
>> >> Leonid Bloch (2):
>> >>   checkpatch: Eliminate false positive in case of comma-space-square
>> >>     bracket
>> >>   checkpatch: Eliminate false positive in case of space before square
>> >>     bracket in a definition
>> >>
>> >>  scripts/checkpatch.pl | 6 +++++-
>> >>  1 file changed, 5 insertions(+), 1 deletion(-)
>> >>
>> >> --
>> >> 2.4.3
>> >>
>>
>
>

[-- Attachment #2: Type: text/html, Size: 2808 bytes --]

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Markus Armbruster]

Copying Paolo.

Leonid Bloch <leonid@daynix.com> writes:

> This series addresses two cases where errors were printed if whitespaces
> appeared in front of a square bracket in places where there should be no
> problem with such placements (please see messages of individual commits).
>
> Leonid Bloch (2):
>   checkpatch: Eliminate false positive in case of comma-space-square
>     bracket
>   checkpatch: Eliminate false positive in case of space before square
>     bracket in a definition
>
>  scripts/checkpatch.pl | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Leonid Bloch]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

ping

http://patchwork.ozlabs.org/patch/537763
http://patchwork.ozlabs.org/patch/537762

On Mon, Jan 11, 2016 at 2:12 PM, Markus Armbruster <armbru@redhat.com>
wrote:

> Copying Paolo.
>
> Leonid Bloch <leonid@daynix.com> writes:
>
> > This series addresses two cases where errors were printed if whitespaces
> > appeared in front of a square bracket in places where there should be no
> > problem with such placements (please see messages of individual commits).
> >
> > Leonid Bloch (2):
> >   checkpatch: Eliminate false positive in case of comma-space-square
> >     bracket
> >   checkpatch: Eliminate false positive in case of space before square
> >     bracket in a definition
> >
> >  scripts/checkpatch.pl | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
>
>

[-- Attachment #2: Type: text/html, Size: 1528 bytes --]

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Leonid Bloch]

ping

http://patchwork.ozlabs.org/patch/537763
http://patchwork.ozlabs.org/patch/537762

On Sun, Jan 31, 2016 at 4:13 PM, Leonid Bloch <leonid@daynix.com> wrote:
> ping
>
> http://patchwork.ozlabs.org/patch/537763
> http://patchwork.ozlabs.org/patch/537762
>
> On Mon, Jan 11, 2016 at 2:12 PM, Markus Armbruster <armbru@redhat.com>
> wrote:
>>
>> Copying Paolo.
>>
>> Leonid Bloch <leonid@daynix.com> writes:
>>
>> > This series addresses two cases where errors were printed if whitespaces
>> > appeared in front of a square bracket in places where there should be no
>> > problem with such placements (please see messages of individual
>> > commits).
>> >
>> > Leonid Bloch (2):
>> >   checkpatch: Eliminate false positive in case of comma-space-square
>> >     bracket
>> >   checkpatch: Eliminate false positive in case of space before square
>> >     bracket in a definition
>> >
>> >  scripts/checkpatch.pl | 6 +++++-
>> >  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

[Paolo Bonzini]

On 11/02/2016 10:43, Leonid Bloch wrote:
> ping
> 
> http://patchwork.ozlabs.org/patch/537763
> http://patchwork.ozlabs.org/patch/537762
> 
> On Sun, Jan 31, 2016 at 4:13 PM, Leonid Bloch <leonid@daynix.com> wrote:
>> ping
>>
>> http://patchwork.ozlabs.org/patch/537763
>> http://patchwork.ozlabs.org/patch/537762
>>
>> On Mon, Jan 11, 2016 at 2:12 PM, Markus Armbruster <armbru@redhat.com>
>> wrote:
>>>
>>> Copying Paolo.
>>>
>>> Leonid Bloch <leonid@daynix.com> writes:
>>>
>>>> This series addresses two cases where errors were printed if whitespaces
>>>> appeared in front of a square bracket in places where there should be no
>>>> problem with such placements (please see messages of individual
>>>> commits).
>>>>
>>>> Leonid Bloch (2):
>>>>   checkpatch: Eliminate false positive in case of comma-space-square
>>>>     bracket
>>>>   checkpatch: Eliminate false positive in case of space before square
>>>>     bracket in a definition
>>>>
>>>>  scripts/checkpatch.pl | 6 +++++-
>>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>

Thanks, applied to my queue.

Paolo