From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsFTF-0004VZ-Fs for qemu-devel@nongnu.org; Fri, 30 Oct 2015 15:36:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsFTC-0002ww-Ah for qemu-devel@nongnu.org; Fri, 30 Oct 2015 15:36:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsFTC-0002ws-5G for qemu-devel@nongnu.org; Fri, 30 Oct 2015 15:36:14 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id A2A3BA2C3F for ; Fri, 30 Oct 2015 19:36:13 +0000 (UTC) From: Eduardo Habkost Date: Fri, 30 Oct 2015 17:36:06 -0200 Message-Id: <1446233769-7892-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH RESEND v2 0/3] pc: Set hw_version on all machine classes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Marcel Apfelbaum , Laszlo Ersek , "Michael S. Tsirkin" In 2012, QEMU had a bug where it exposed QEMU version information to the guest, meaning a QEMU upgrade would expose different hardware to the guest OS even if the same machine-type is being used. The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, on all machines up to pc-1.0. But we kept introducing the same bug on all newer machines since then. That means we are breaking guest ABI every time QEMU was upgraded. Fix this by setting the hw_version on all PC machines, making sure the hardware won't change when upgrading QEMU. Eduardo Habkost (3): pc: Set hw_version on all machine classes osdep: Rename qemu_{get,set}_version() to qemu_{,set_}hw_version() megasas: Use qemu_hw_version() instead of QEMU_VERSION hw/arm/nseries.c | 2 +- hw/i386/pc_piix.c | 13 +++++++++++++ hw/i386/pc_q35.c | 10 ++++++++++ hw/ide/core.c | 2 +- hw/scsi/megasas.c | 2 +- hw/scsi/scsi-bus.c | 2 +- hw/scsi/scsi-disk.c | 2 +- include/qemu/osdep.h | 4 ++-- target-i386/cpu.c | 2 +- util/osdep.c | 10 +++++----- vl.c | 2 +- 11 files changed, 37 insertions(+), 14 deletions(-) -- 2.1.0