From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: vsementsov@virtuozzo.com,
Xiao Guangrong <guangrong.xiao@linux.intel.com>,
ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v7 31/35] nvdimm acpi: support Get Namespace Label Data function
Date: Mon, 2 Nov 2015 17:13:33 +0800 [thread overview]
Message-ID: <1446455617-129562-32-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com>
Function 5 is used to get Namespace Label Data
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
hw/acpi/nvdimm.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index cdc361c..f30e2ff 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -428,6 +428,7 @@ struct NvdimmDsmIn {
union {
uint8_t arg3[0];
NvdimmFuncInSetLabelData func_set_label_data;
+ NvdimmFuncInGetLabelData func_get_label_data;
};
} QEMU_PACKED;
typedef struct NvdimmDsmIn NvdimmDsmIn;
@@ -527,6 +528,65 @@ static void nvdimm_dsm_func_label_size(NVDIMMDevice *nvdimm, GArray *out)
g_array_append_vals(out, &func_label_size, sizeof(func_label_size));
}
+static uint32_t nvdimm_rw_label_data_check(NVDIMMDevice *nvdimm,
+ uint32_t offset, uint32_t length)
+{
+ if (offset + length < offset) {
+ nvdimm_debug("offset %#x + length %#x is overflow.\n", offset,
+ length);
+ return NVDIMM_DSM_DEV_STATUS_INVALID_PARAS;
+ }
+
+ if (nvdimm->label_size < offset + length) {
+ nvdimm_debug("position %#x is beyond label data (len = %#lx).\n",
+ offset + length, nvdimm->label_size);
+ return NVDIMM_DSM_DEV_STATUS_INVALID_PARAS;
+ }
+
+ if (length > nvdimm_get_max_xfer_label_size()) {
+ nvdimm_debug("length (%#x) is larger than max_xfer (%#x).\n",
+ length, nvdimm_get_max_xfer_label_size());
+ return NVDIMM_DSM_DEV_STATUS_INVALID_PARAS;
+ }
+
+ return NVDIMM_DSM_STATUS_SUCCESS;
+}
+
+/*
+ * DSM Spec Rev1 4.5 Get Namespace Label Data (Function Index 5).
+ */
+static void nvdimm_dsm_func_get_label_data(NVDIMMDevice *nvdimm,
+ NvdimmDsmIn *in, GArray *out)
+{
+ NVDIMMClass *nvc = NVDIMM_GET_CLASS(nvdimm);
+ NvdimmFuncInGetLabelData *get_label_data = &in->func_get_label_data;
+ void *buf;
+ uint32_t status;
+
+ le32_to_cpus(&get_label_data->offset);
+ le32_to_cpus(&get_label_data->length);
+
+ nvdimm_debug("Read Label Data: offset %#x length %#x.\n",
+ get_label_data->offset, get_label_data->length);
+
+ status = nvdimm_rw_label_data_check(nvdimm, get_label_data->offset,
+ get_label_data->length);
+ if (status != NVDIMM_DSM_STATUS_SUCCESS) {
+ goto exit;
+ }
+
+ /* write nvdimm_func_out_get_label_data.status. */
+ nvdimm_dsm_write_status(out, status);
+ /* write nvdimm_func_out_get_label_data.out_buf. */
+ buf = acpi_data_push(out, get_label_data->length);
+ nvc->read_label_data(nvdimm, buf, get_label_data->length,
+ get_label_data->offset);
+ return;
+
+exit:
+ nvdimm_dsm_write_status(out, status);
+}
+
static void nvdimm_dsm_device(NvdimmDsmIn *in, GArray *out)
{
GSList *list = nvdimm_get_plugged_device_list();
@@ -554,6 +614,9 @@ static void nvdimm_dsm_device(NvdimmDsmIn *in, GArray *out)
case 0x4 /* Get Namespace Label Size */:
nvdimm_dsm_func_label_size(nvdimm, out);
goto free;
+ case 0x5 /* Get Namespace Label Data */:
+ nvdimm_dsm_func_get_label_data(nvdimm, in, out);
+ goto free;
default:
status = NVDIMM_DSM_STATUS_NOT_SUPPORTED;
};
--
1.8.3.1
next prev parent reply other threads:[~2015-11-02 9:20 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 9:13 [Qemu-devel] [PATCH v7 00/35] implement vNVDIMM Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 01/35] acpi: add aml_derefof Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 02/35] acpi: add aml_sizeof Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 03/35] acpi: add aml_create_field Xiao Guangrong
2015-11-03 6:14 ` Shannon Zhao
2015-11-03 14:52 ` Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 04/35] acpi: add aml_concatenate Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 05/35] acpi: add aml_object_type Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 06/35] acpi: add aml_method_serialized Xiao Guangrong
2015-11-03 12:30 ` Igor Mammedov
2015-11-03 13:27 ` Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 07/35] util: introduce qemu_file_get_page_size() Xiao Guangrong
2015-11-02 13:56 ` Vladimir Sementsov-Ogievskiy
2015-11-06 15:36 ` Eduardo Habkost
2015-11-09 4:36 ` Xiao Guangrong
2015-11-09 18:34 ` Eduardo Habkost
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 08/35] exec: allow memory to be allocated from any kind of path Xiao Guangrong
2015-11-02 14:51 ` Vladimir Sementsov-Ogievskiy
2015-11-02 15:22 ` Xiao Guangrong
2015-11-02 15:52 ` Vladimir Sementsov-Ogievskiy
2015-11-03 23:00 ` Eduardo Habkost
2015-11-04 3:12 ` Xiao Guangrong
2015-11-04 12:40 ` Eduardo Habkost
2015-11-04 14:22 ` Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 09/35] exec: allow file_ram_alloc to work on file Xiao Guangrong
2015-11-02 15:12 ` Vladimir Sementsov-Ogievskiy
2015-11-02 15:25 ` Xiao Guangrong
2015-11-02 15:58 ` Vladimir Sementsov-Ogievskiy
2015-11-02 21:12 ` Paolo Bonzini
2015-11-03 3:56 ` Xiao Guangrong
2015-11-03 13:55 ` Paolo Bonzini
2015-11-03 14:26 ` Xiao Guangrong
2015-11-03 12:34 ` Igor Mammedov
2015-11-03 13:32 ` Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 10/35] hostmem-file: clean up memory allocation Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 11/35] util: introduce qemu_file_getlength() Xiao Guangrong
2015-11-02 15:26 ` Vladimir Sementsov-Ogievskiy
2015-11-03 23:21 ` Eduardo Habkost
2015-11-04 3:17 ` Xiao Guangrong
2015-11-04 14:44 ` Eduardo Habkost
2015-11-04 14:44 ` Xiao Guangrong
2015-11-06 15:50 ` Eduardo Habkost
2015-11-09 4:44 ` Xiao Guangrong
2015-11-09 19:21 ` Eduardo Habkost
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 12/35] util: let qemu_fd_getlength support block device Xiao Guangrong
2015-11-02 16:11 ` Vladimir Sementsov-Ogievskiy
2015-11-02 16:21 ` Xiao Guangrong
2015-11-06 15:44 ` Eduardo Habkost
2015-11-06 15:48 ` Eduardo Habkost
2015-11-06 15:54 ` Eduardo Habkost
2015-11-09 5:58 ` Xiao Guangrong
2015-11-09 18:43 ` Eduardo Habkost
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 13/35] hostmem-file: use whole file size if possible Xiao Guangrong
2015-11-02 17:09 ` Vladimir Sementsov-Ogievskiy
2015-11-03 14:51 ` Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 14/35] pc-dimm: remove DEFAULT_PC_DIMMSIZE Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 15/35] pc-dimm: make pc_existing_dimms_capacity static and rename it Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 16/35] pc-dimm: drop the prefix of pc-dimm Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 17/35] stubs: rename qmp_pc_dimm_device_list.c Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 18/35] pc-dimm: rename pc-dimm.c and pc-dimm.h Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 19/35] dimm: abstract dimm device from pc-dimm Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Xiao Guangrong
2015-11-02 12:19 ` Vladimir Sementsov-Ogievskiy
2015-11-02 13:08 ` Xiao Guangrong
2015-11-02 14:26 ` Vladimir Sementsov-Ogievskiy
2015-11-02 15:06 ` Xiao Guangrong
2015-11-02 16:16 ` Vladimir Sementsov-Ogievskiy
2015-11-03 14:47 ` Xiao Guangrong
2015-11-05 8:53 ` Vladimir Sementsov-Ogievskiy
2015-11-05 17:29 ` Eduardo Habkost
2015-11-06 2:50 ` Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 21/35] dimm: keep the state of the whole backend memory Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 22/35] dimm: introduce realize callback Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 23/35] nvdimm: implement NVDIMM device abstract Xiao Guangrong
2015-11-13 16:53 ` Vladimir Sementsov-Ogievskiy
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 24/35] docs: add NVDIMM ACPI documentation Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI Xiao Guangrong
2015-11-05 9:58 ` Igor Mammedov
2015-11-05 10:15 ` Xiao Guangrong
2015-11-05 13:03 ` Igor Mammedov
2015-11-05 13:33 ` Xiao Guangrong
2015-11-05 14:49 ` Igor Mammedov
2015-11-06 8:31 ` Xiao Guangrong
2015-11-06 8:56 ` Xiao Guangrong
2015-11-09 11:13 ` Igor Mammedov
2015-11-11 3:01 ` [Qemu-devel] Ask for ACK (was Re: [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI) Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 26/35] nvdimm acpi: build ACPI NFIT table Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 27/35] nvdimm acpi: build ACPI nvdimm devices Xiao Guangrong
2015-11-03 13:13 ` Igor Mammedov
2015-11-03 14:22 ` Xiao Guangrong
2015-11-04 8:56 ` Igor Mammedov
2015-11-04 14:11 ` Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 28/35] nvdimm acpi: save arg3 for NVDIMM device _DSM method Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 29/35] nvdimm acpi: support function 0 Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 30/35] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2015-11-02 9:13 ` Xiao Guangrong [this message]
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 32/35] nvdimm acpi: support Set Namespace Label Data function Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 33/35] nvdimm: allow using whole backend memory as pmem Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 34/35] nvdimm acpi: support _FIT method Xiao Guangrong
2015-11-02 9:13 ` [Qemu-devel] [PATCH v7 35/35] nvdimm: add maintain info Xiao Guangrong
2015-11-02 11:51 ` [Qemu-devel] [PATCH v7 00/35] implement vNVDIMM Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446455617-129562-32-git-send-email-guangrong.xiao@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).