From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtFk0-0004H2-2I for qemu-devel@nongnu.org; Mon, 02 Nov 2015 09:05:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtFjt-0004K7-QU for qemu-devel@nongnu.org; Mon, 02 Nov 2015 09:05:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtFjt-0004Jr-Dc for qemu-devel@nongnu.org; Mon, 02 Nov 2015 09:05:37 -0500 From: Paolo Bonzini Date: Mon, 2 Nov 2015 15:05:34 +0100 Message-Id: <1446473134-4330-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Mark Cave-Ayland This is reported by Coverity. The algorithm description at ftp://ftp.icm.edu.pl/packages/ggi/doc/hw/sparc/Sparc.pdf suggests that the 32-bit parts of rs2, after the left shift, is treated as a 64-bit integer. Bits 32 and above are used to do the saturating truncation. Signed-off-by: Paolo Bonzini --- target-sparc/vis_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c index 383cc8b..45fc7db 100644 --- a/target-sparc/vis_helper.c +++ b/target-sparc/vis_helper.c @@ -447,7 +447,7 @@ uint32_t helper_fpackfix(uint64_t gsr, uint64_t rs2) for (word = 0; word < 2; word++) { uint32_t val; int32_t src = rs2 >> (word * 32); - int64_t scaled = src << scale; + int64_t scaled = (int64_t)src << scale; int64_t from_fixed = scaled >> 16; val = (from_fixed < -32768 ? -32768 : -- 2.5.0