From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtYPR-00009y-9v for qemu-devel@nongnu.org; Tue, 03 Nov 2015 05:01:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtYPO-0003y3-H4 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 05:01:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtYPO-0003xv-Br for qemu-devel@nongnu.org; Tue, 03 Nov 2015 05:01:42 -0500 From: Gerd Hoffmann Date: Tue, 3 Nov 2015 11:01:31 +0100 Message-Id: <1446544891-3600-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1446544891-3600-1-git-send-email-kraxel@redhat.com> References: <1446544891-3600-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 6/6] vnc: fix bug: vnc server can't start when 'to' is specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Yang Hongyang From: Yang Hongyang commit e0d03b8ceb52 converted VNC startup to use SocketAddress, the interface socket_listen don't have a port_offset param, so we need to add the port offset (5900) to both 'port' and 'to' opts. currently only 'port' is added by offset. This patch add the port offset to 'to' opts. Signed-off-by: Yang Hongyang Reviewed-by: Daniel P. Berrange Message-id: 1445926252-14830-1-git-send-email-hongyang.yang@easystack.cn Cc: Daniel P. Berrange Cc: Eric Blake Cc: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 166d1b5..a47f2b3 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3572,6 +3572,8 @@ void vnc_display_open(const char *id, Error **errp) if (to) { saddr->u.inet->has_to = true; saddr->u.inet->to = to; + saddr->u.inet->has_to = true; + saddr->u.inet->to = to + 5900; } saddr->u.inet->ipv4 = saddr->u.inet->has_ipv4 = has_ipv4; saddr->u.inet->ipv6 = saddr->u.inet->has_ipv6 = has_ipv6; -- 1.8.3.1