From: Wen Congyang <wency@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>, Fam Zheng <famz@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu block <qemu-block@nongnu.org>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael R. Hines" <mrhines@linux.vnet.ibm.com>,
Gonglei <arei.gonglei@huawei.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: [Qemu-devel] [PATCH v11 09/12] quorum: implement block driver interfaces for block replication
Date: Tue, 3 Nov 2015 18:58:46 +0800 [thread overview]
Message-ID: <1446548329-17475-10-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1446548329-17475-1-git-send-email-wency@cn.fujitsu.com>
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
block/quorum.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 78 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index 79afb20..7cb5f91 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -82,6 +82,8 @@ typedef struct BDRVQuorumState {
*/
QuorumReadPattern read_pattern;
+
+ int replication_index; /* store which child supports block replication */
} BDRVQuorumState;
typedef struct QuorumAIOCB QuorumAIOCB;
@@ -943,6 +945,7 @@ static int quorum_open(BlockDriverState *bs, QDict *options, int flags,
}
g_free(opened);
+ s->replication_index = -1;
goto exit;
close_exit:
@@ -1083,6 +1086,77 @@ static void quorum_refresh_filename(BlockDriverState *bs)
bs->full_open_options = opts;
}
+static void quorum_start_replication(BlockDriverState *bs, ReplicationMode mode,
+ Error **errp)
+{
+ BDRVQuorumState *s = bs->opaque;
+ int count = 0, i, index;
+ Error *local_err = NULL;
+
+ /*
+ * TODO: support REPLICATION_MODE_SECONDARY if we allow secondary
+ * QEMU becoming primary QEMU.
+ */
+ if (mode != REPLICATION_MODE_PRIMARY) {
+ error_setg(errp, "The replication mode for quorum should be 'primary'");
+ return;
+ }
+
+ if (s->read_pattern != QUORUM_READ_PATTERN_FIFO) {
+ error_setg(errp, "Block replication needs read pattern 'fifo'");
+ return;
+ }
+
+ for (i = 0; i < s->num_children; i++) {
+ bdrv_start_replication(s->children[i]->bs, mode, &local_err);
+ if (local_err) {
+ error_free(local_err);
+ local_err = NULL;
+ } else {
+ count++;
+ index = i;
+ }
+ }
+
+ if (count == 0) {
+ error_setg(errp, "No child supports block replication");
+ } else if (count > 1) {
+ for (i = 0; i < s->num_children; i++) {
+ bdrv_stop_replication(s->children[i]->bs, false, NULL);
+ }
+ error_setg(errp, "Too many children support block replication");
+ } else {
+ s->replication_index = index;
+ }
+}
+
+static void quorum_do_checkpoint(BlockDriverState *bs, Error **errp)
+{
+ BDRVQuorumState *s = bs->opaque;
+
+ if (s->replication_index < 0) {
+ error_setg(errp, "Block replication is not running");
+ return;
+ }
+
+ bdrv_do_checkpoint(s->children[s->replication_index]->bs, errp);
+}
+
+static void quorum_stop_replication(BlockDriverState *bs, bool failover,
+ Error **errp)
+{
+ BDRVQuorumState *s = bs->opaque;
+
+ if (s->replication_index < 0) {
+ error_setg(errp, "Block replication is not running");
+ return;
+ }
+
+ bdrv_stop_replication(s->children[s->replication_index]->bs, failover,
+ errp);
+ s->replication_index = -1;
+}
+
static BlockDriver bdrv_quorum = {
.format_name = "quorum",
.protocol_name = "quorum",
@@ -1109,6 +1183,10 @@ static BlockDriver bdrv_quorum = {
.is_filter = true,
.bdrv_recurse_is_first_non_filter = quorum_recurse_is_first_non_filter,
+
+ .bdrv_start_replication = quorum_start_replication,
+ .bdrv_do_checkpoint = quorum_do_checkpoint,
+ .bdrv_stop_replication = quorum_stop_replication,
};
static void bdrv_quorum_init(void)
--
2.4.3
next prev parent reply other threads:[~2015-11-03 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 10:58 [Qemu-devel] [PATCH v11 00/12] Block replication is a very important feature which is used for Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 01/12] unblock backup operations in backing file Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 02/12] Store parent BDS in BdrvChild Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 03/12] allow writing to the backing file Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 04/12] Backup: clear all bitmap when doing block checkpoint Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 05/12] Allow creating backup jobs when opening BDS Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 06/12] block: make bdrv_put_ref_bh_schedule() as a public API Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 07/12] docs: block replication's description Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 08/12] Add new block driver interfaces to control block replication Wen Congyang
2015-11-03 10:58 ` Wen Congyang [this message]
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 10/12] Implement new driver for " Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 11/12] support replication driver in blockdev-add Wen Congyang
2015-11-03 10:58 ` [Qemu-devel] [PATCH v11 12/12] Add a new API to start/stop replication, do checkpoint to all BDSes Wen Congyang
2015-11-12 9:03 ` [Qemu-devel] [PATCH v11 00/12] Block replication for continuous checkpoints Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446548329-17475-10-git-send-email-wency@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).