From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtZZJ-0003pX-SZ for qemu-devel@nongnu.org; Tue, 03 Nov 2015 06:16:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtZZF-0007b5-Th for qemu-devel@nongnu.org; Tue, 03 Nov 2015 06:16:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtZZF-0007at-Ot for qemu-devel@nongnu.org; Tue, 03 Nov 2015 06:15:57 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 5A593C0D61AA for ; Tue, 3 Nov 2015 11:15:57 +0000 (UTC) From: Gerd Hoffmann Date: Tue, 3 Nov 2015 12:15:53 +0100 Message-Id: <1446549354-26147-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1446549354-26147-1-git-send-email-kraxel@redhat.com> References: <1446549354-26147-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/2] ehci: clear suspend bit on detach List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hans de Goede , Gerd Hoffmann When a device is detached, clear the suspend bit (PORTSC_SUSPEND) in the port status register. The specs are not *that* clear what is supposed to happen in case a suspended device is unplugged. But the enable bit (PORTSC_PED) is cleared, and the specs mention setting suspend with enable being unset is undefined behavior. So clearing them both looks reasonable, and it actually fixes the reported bug. https://bugzilla.redhat.com/show_bug.cgi?id=1268879 Cc: Hans de Goede Signed-off-by: Gerd Hoffmann Reviewed-by: Hans de Goede Message-id: 1445413462-18004-1-git-send-email-kraxel@redhat.com --- hw/usb/hcd-ehci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 64a54c6..4e2161b 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -726,7 +726,7 @@ static void ehci_detach(USBPort *port) ehci_queues_rip_device(s, port->dev, 0); ehci_queues_rip_device(s, port->dev, 1); - *portsc &= ~(PORTSC_CONNECT|PORTSC_PED); + *portsc &= ~(PORTSC_CONNECT|PORTSC_PED|PORTSC_SUSPEND); *portsc |= PORTSC_CSC; ehci_raise_irq(s, USBSTS_PCD); -- 1.8.3.1