From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 6/7] vl.c: Improve warnings on use of deprecated options
Date: Tue, 3 Nov 2015 19:38:02 +0100 [thread overview]
Message-ID: <1446575883-24544-7-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1446575883-24544-1-git-send-email-armbru@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
Simplify warnings about deprecated options by rewriting them as
"warning: ignoring deprecated option".
Reword -no-kvm-pit-reinjection deprecation warning.
Suggested-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1446217682-24421-10-git-send-email-ehabkost@redhat.com>
[Squashed in
Message-Id: <1446217682-24421-11-git-send-email-ehabkost@redhat.com>
and updated commit message]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
vl.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index 2d48e22..e2999c9 100644
--- a/vl.c
+++ b/vl.c
@@ -3657,8 +3657,7 @@ int main(int argc, char **argv, char **envp)
qemu_opts_parse_noisily(olist, "accel=tcg", false);
break;
case QEMU_OPTION_no_kvm_pit: {
- error_report("warning: KVM PIT can no longer be disabled "
- "separately");
+ error_report("warning: ignoring deprecated option");
break;
}
case QEMU_OPTION_no_kvm_pit_reinjection: {
@@ -3671,8 +3670,8 @@ int main(int argc, char **argv, char **envp)
{ /* end of list */ }
};
- error_report("warning: option deprecated, use "
- "lost_tick_policy property of kvm-pit instead");
+ error_report("warning: deprecated, replaced by "
+ "-global kvm-pit.lost_tick_policy=discard");
qdev_prop_register_global_list(kvm_pit_lost_tick_policy);
break;
}
@@ -3795,8 +3794,7 @@ int main(int argc, char **argv, char **envp)
}
break;
case QEMU_OPTION_tdf:
- error_report("warning: user space PIT time drift fix "
- "is no longer supported");
+ error_report("warning: ignoring deprecated option");
break;
case QEMU_OPTION_name:
opts = qemu_opts_parse_noisily(qemu_find_opts("name"),
--
2.4.3
next prev parent reply other threads:[~2015-11-03 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 18:37 [Qemu-devel] [PULL 0/7] vl.c: Error message rework Markus Armbruster
2015-11-03 18:37 ` [Qemu-devel] [PULL 1/7] vl.c: Replace fprintf(stderr) with error_report() Markus Armbruster
2015-11-03 18:37 ` [Qemu-devel] [PULL 2/7] vl.c: Remove periods and exclamation points from error messages Markus Armbruster
2015-11-03 18:37 ` [Qemu-devel] [PULL 3/7] vl.c: Use "warning:" prefix consistently on warnings Markus Armbruster
2015-11-03 18:38 ` [Qemu-devel] [PULL 4/7] vl.c: Remove unnecessary uppercase in error messages Markus Armbruster
2015-11-03 18:38 ` [Qemu-devel] [PULL 5/7] vl.c: Touch up " Markus Armbruster
2015-11-03 18:38 ` Markus Armbruster [this message]
2015-11-03 18:38 ` [Qemu-devel] [PULL 7/7] vl.c: Use "%s support is disabled" error messages consistently Markus Armbruster
2015-11-05 10:10 ` [Qemu-devel] [PULL 0/7] vl.c: Error message rework Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446575883-24544-7-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).