qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bo Tu <tubo@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, mreitz@redhat.com,
	armbru@redhat.com, mimu@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 3/4] qemu-iotests: s390x: fix test 068
Date: Wed,  4 Nov 2015 10:26:57 +0800	[thread overview]
Message-ID: <1446604018-14025-4-git-send-email-tubo@linux.vnet.ibm.com> (raw)
In-Reply-To: <1446604018-14025-1-git-send-email-tubo@linux.vnet.ibm.com>

Now, s390-virtio-ccw is default machine and s390-ccw.img is default boot
loader. If the s390-virtio-ccw machine finds no device to load from and
errors out, then emits a panic and exits the vm. This breaks test cases
068 for s390x.
Adding the parameter of "-no-shutdown" for s390-ccw-virtio will pause VM
before shutdown.

Reviewed-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Bo Tu <tubo@linux.vnet.ibm.com>
---
 tests/qemu-iotests/068 | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/068 b/tests/qemu-iotests/068
index b72e555..58d1d80 100755
--- a/tests/qemu-iotests/068
+++ b/tests/qemu-iotests/068
@@ -50,13 +50,23 @@ echo
 echo "=== Saving and reloading a VM state to/from a qcow2 image ==="
 echo
 _make_test_img $IMG_SIZE
+
+case "$QEMU_DEFAULT_MACHINE" in
+  s390-ccw-virtio)
+      platform_parm="-no-shutdown -machine accel=kvm"
+      ;;
+  *)
+      platform_parm=""
+      ;;
+esac
+
 # Give qemu some time to boot before saving the VM state
 bash -c 'sleep 1; echo -e "savevm 0\nquit"' |\
-    $QEMU -nographic -monitor stdio -serial none -hda "$TEST_IMG" |\
+    $QEMU $platform_parm -nographic -monitor stdio -serial none -hda "$TEST_IMG" |\
     _filter_qemu
 # Now try to continue from that VM state (this should just work)
 echo quit |\
-    $QEMU -nographic -monitor stdio -serial none -hda "$TEST_IMG" -loadvm 0 |\
+    $QEMU $platform_parm -nographic -monitor stdio -serial none -hda "$TEST_IMG" -loadvm 0 |\
     _filter_qemu
 
 # success, all done
-- 
2.3.0

  parent reply	other threads:[~2015-11-04  2:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  2:26 [Qemu-devel] [PATCH v2 0/4] Update tests/qemu-iotests failing cases for the s390 platform Bo Tu
2015-11-04  2:26 ` [Qemu-devel] [PATCH v2 1/4] qemu-iotests: refine common.config Bo Tu
2015-11-18 16:45   ` Max Reitz
2015-11-19  5:58     ` tu bo
2015-11-04  2:26 ` [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051 Bo Tu
2015-11-18 16:52   ` Max Reitz
2015-11-19  7:28     ` tu bo
2015-11-20 16:24       ` Max Reitz
2015-11-23  3:34         ` tu bo
2015-11-24 21:17         ` Sascha Silbe
2015-11-25 15:41           ` Max Reitz
2015-11-26 10:15             ` tu bo
2015-11-04  2:26 ` Bo Tu [this message]
2015-11-18 16:57   ` [Qemu-devel] [PATCH v2 3/4] qemu-iotests: s390x: fix test 068 Max Reitz
2015-11-04  2:26 ` [Qemu-devel] [PATCH v2 4/4] qemu-iotests: disable VNC server for test 120 Bo Tu
2015-11-18 16:56   ` Max Reitz
2015-11-19  7:06     ` tu bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446604018-14025-4-git-send-email-tubo@linux.vnet.ibm.com \
    --to=tubo@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mimu@linux.vnet.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=silbe@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).