From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Hannes Reinecke <hare@suse.de>
Subject: [Qemu-devel] [PULL 08/14] megasas: Use qemu_hw_version() instead of QEMU_VERSION
Date: Wed, 4 Nov 2015 17:18:26 +0100 [thread overview]
Message-ID: <1446653912-116150-9-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1446653912-116150-1-git-send-email-pbonzini@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
Guest visible data shouldn't change with a simple QEMU upgrade, so use
qemu_hw_version() to ensure it won't change (as long as the machine
class being used has hw_version set).
Cc: Hannes Reinecke <hare@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-block@nongnu.org
Reviewed-by: Hannes Reinecke <hare@suse.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1446233769-7892-4-git-send-email-ehabkost@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/megasas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index dcd724e..d7dc667 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -757,7 +757,7 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)
memcpy(info.product_name, base_class->product_name, 24);
snprintf(info.serial_number, 32, "%s", s->hba_serial);
- snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION);
+ snprintf(info.package_version, 0x60, "%s-QEMU", qemu_hw_version());
memcpy(info.image_component[0].name, "APP", 3);
snprintf(info.image_component[0].version, 10, "%s-QEMU",
base_class->product_version);
--
1.8.3.1
next prev parent reply other threads:[~2015-11-04 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 16:18 [Qemu-devel] [PULL 00/14] Misc changes for QEMU 2.4-rc1 Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 01/14] file_ram_alloc: propagate error to caller instead of terminating QEMU Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 02/14] scripts/text2pod.pl: Escape left brace Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 03/14] target-i386: fix pcmpxstrx equal-ordered (strstr) mode Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 04/14] ioport: do not use CPU_LOG_IOPORT Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 05/14] qemu-log: remove -d ioport Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 06/14] pc: Set hw_version on all machine classes Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 07/14] osdep: Rename qemu_{get, set}_version() to qemu_{, set_}hw_version() Paolo Bonzini
2015-11-04 16:18 ` Paolo Bonzini [this message]
2015-11-04 16:18 ` [Qemu-devel] [PULL 09/14] memory: call begin, log_start and commit when registering a new listener Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 10/14] cpu-exec: Fix compiler warning (-Werror=clobbered) Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 11/14] configure: disallow ccache during compile tests Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 12/14] backends/hostmem-file: Allow to specify full pathname for backing file Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 13/14] iscsi: Translate scsi sense into error code Paolo Bonzini
2015-11-04 16:18 ` [Qemu-devel] [PULL 14/14] configure: disable FORTIFY_SOURCE under clang Paolo Bonzini
2015-11-04 16:34 ` [Qemu-devel] [PULL 00/14] Misc changes for QEMU 2.4-rc1 Peter Maydell
2015-11-04 16:36 ` Paolo Bonzini
2015-11-05 4:58 ` Fam Zheng
2015-11-05 8:02 ` Peter Maydell
2015-11-04 16:53 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446653912-116150-9-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hare@suse.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).