From: "Denis V. Lunev" <den@openvz.org>
Cc: "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 3/3] block: guard bdrv_drain in bdrv_close with aio_context_acquire
Date: Wed, 4 Nov 2015 20:27:24 +0300 [thread overview]
Message-ID: <1446658044-22042-4-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1446658044-22042-1-git-send-email-den@openvz.org>
bdrv_close is called in tooooo much places to properly track at the moment.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Stefan Hajnoczi <stefanha@redhat.com>
---
block.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block.c b/block.c
index e9f40dc..98b0b66 100644
--- a/block.c
+++ b/block.c
@@ -1895,6 +1895,7 @@ void bdrv_reopen_abort(BDRVReopenState *reopen_state)
void bdrv_close(BlockDriverState *bs)
{
BdrvAioNotifier *ban, *ban_next;
+ AioContext *ctx;
if (bs->job) {
block_job_cancel_sync(bs->job);
@@ -1905,9 +1906,13 @@ void bdrv_close(BlockDriverState *bs)
bdrv_io_limits_disable(bs);
}
+ ctx = bdrv_get_aio_context(bs);
+ aio_context_acquire(ctx);
bdrv_drain(bs); /* complete I/O */
bdrv_flush(bs);
bdrv_drain(bs); /* in case flush left pending I/O */
+ aio_context_release(ctx);
+
notifier_list_notify(&bs->close_notifiers, bs);
if (bs->blk) {
--
2.5.0
next prev parent reply other threads:[~2015-11-04 17:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 17:27 [Qemu-devel] [PATCH 2.5 v2 0/3] misc missed aio_context_acquire for bdrv_drain Denis V. Lunev
2015-11-04 17:27 ` [Qemu-devel] [PATCH 1/3] block: add missed aio_context_acquire around bdrv_set_aio_context Denis V. Lunev
2015-11-06 13:35 ` Stefan Hajnoczi
2015-11-06 14:09 ` Denis V. Lunev
2015-11-06 14:19 ` Denis V. Lunev
2015-11-06 14:49 ` Stefan Hajnoczi
2015-11-06 14:44 ` Stefan Hajnoczi
2015-11-06 14:51 ` Denis V. Lunev
2015-11-06 14:55 ` Stefan Hajnoczi
2015-11-04 17:27 ` [Qemu-devel] [PATCH 2/3] blockdev: acquire AioContext in hmp_commit() Denis V. Lunev
2015-11-06 15:41 ` Stefan Hajnoczi
2015-11-04 17:27 ` Denis V. Lunev [this message]
2015-11-06 13:44 ` [Qemu-devel] [PATCH 3/3] block: guard bdrv_drain in bdrv_close with aio_context_acquire Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446658044-22042-4-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).