From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuGEI-00043i-GU for qemu-devel@nongnu.org; Thu, 05 Nov 2015 03:49:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuGEF-0002hf-AY for qemu-devel@nongnu.org; Thu, 05 Nov 2015 03:49:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuGEF-0002hI-55 for qemu-devel@nongnu.org; Thu, 05 Nov 2015 03:49:07 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 42B61130B for ; Thu, 5 Nov 2015 08:49:06 +0000 (UTC) Message-ID: <1446713343.30393.16.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 05 Nov 2015 09:49:03 +0100 In-Reply-To: <1446595225-23608-3-git-send-email-bsd@redhat.com> References: <1446595225-23608-1-git-send-email-bsd@redhat.com> <1446595225-23608-3-git-send-email-bsd@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das Cc: qemu-devel@nongnu.org On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: > + /* Add a new watch asap so as to not lose events > */ This comment sounds like there is a race ("asap"). There isn't one, correct ordering (adding the watch before reading the directory) is enough to make sure you don't miss anything. You might see create events for objects already in the tree though, are you prepared to handle that? cheers, Gerd