From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuLk1-0003tj-QV for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:42:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuLjx-0004D0-4c for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:42:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuLjw-0004Cs-Vd for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:42:13 -0500 Message-ID: <1446734529.30393.26.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 05 Nov 2015 15:42:09 +0100 In-Reply-To: References: <1446725610.30393.23.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , QEMU Developers On Do, 2015-11-05 at 12:32 +0000, Peter Maydell wrote: > On 5 November 2015 at 12:13, Gerd Hoffmann wrote: > >> etc, because all the virtio_gpu definitions disappear from > >> include/standard-headers/linux/virtio_gpu.h. > > > > Updates not yet in mainline, they are sitting in drm-next and should > > land during the merge window (i.e. 4.4-rc1 should have them). > > > > I'd suggest to exclude virtio_gpu.h changes when updating linux headers > > for the time being. > > I would strongly prefer it if we could get to a point where > we can say "kernel headers must only be updated from this tree" > and be guaranteed that it always works. This used to be true > with the tree in question being kvm/next, but it doesn't seem > to be so now. If it's going to be common that we have header > changes that don't go via kvm/next, maybe we need to coordinate > a tree that merges together the abi-guaranteed-stable changes > from different places before they hit mainline? Chicken & egg issue in that case because airlied (linux kernel drm maintainer) asked to have the qemu changes merged before taking the virtio-gpu pull request. So I had no other chance than creating the patches with not-yet upstream virtio header changes ... cheers, Gerd