From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next
Date: Thu, 05 Nov 2015 15:58:23 +0100 [thread overview]
Message-ID: <1446735503.30393.35.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA-gky-HqNfTJDtj=5KtfYZ0htza3O=cu02YtRzPOgxaUQ@mail.gmail.com>
On Do, 2015-11-05 at 14:45 +0000, Peter Maydell wrote:
> On 5 November 2015 at 14:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Chicken & egg issue in that case because airlied (linux kernel drm
> > maintainer) asked to have the qemu changes merged before taking the
> > virtio-gpu pull request. So I had no other chance than creating the
> > patches with not-yet upstream virtio header changes ...
>
> Hmm. If I'd realised that at the time I'd have pushed back on it.
> We should never take code that relies on upstream kernel
> ABI that hasn't been accepted by the maintainer yet.
The reason airlied asked for qemu being upstream first is to avoid
having code in the kernel tree not accepted by qemu yet ...
So, one of the two has to go first ;)
When I did the pull requests patches had passed review on both
qemu-devel (qemu side) and dri-devel (kernel side), so this was really
just a formal "wait for qemu" thing with a very low risk of ABI changes,
and airlied pulled it into drm-next only days after it landed in
qemu/master.
cheers,
Gerd
next prev parent reply other threads:[~2015-11-05 14:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 11:42 [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next Peter Maydell
2015-11-05 11:49 ` Paolo Bonzini
2015-11-05 12:13 ` Gerd Hoffmann
2015-11-05 12:32 ` Peter Maydell
2015-11-05 13:23 ` Christian Borntraeger
2015-11-05 13:44 ` Peter Maydell
2015-11-05 13:46 ` Christian Borntraeger
2015-11-05 14:01 ` Paolo Bonzini
2015-11-05 14:30 ` Peter Maydell
2015-11-05 14:52 ` Peter Maydell
2015-11-05 15:03 ` Paolo Bonzini
2015-11-05 14:58 ` Paolo Bonzini
2015-11-05 18:56 ` Peter Maydell
2015-11-05 13:48 ` Laszlo Ersek
2015-11-05 15:52 ` Alex Bennée
2015-11-05 17:05 ` Laszlo Ersek
2015-11-05 17:09 ` Paolo Bonzini
2015-11-05 14:42 ` Gerd Hoffmann
2015-11-05 14:45 ` Peter Maydell
2015-11-05 14:58 ` Gerd Hoffmann [this message]
2015-11-05 15:11 ` Peter Maydell
2015-11-05 17:15 ` Laszlo Ersek
2015-11-05 18:13 ` Cornelia Huck
2015-11-05 18:51 ` Laszlo Ersek
2015-11-06 16:34 ` Alex Bennée
2015-11-06 16:43 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446735503.30393.35.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).