From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37287)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZuLzh-0005xQ-HW
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:58:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZuLze-00010s-AR
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:58:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36990)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZuLze-00010X-50
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 09:58:26 -0500
Message-ID: <1446735503.30393.35.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 05 Nov 2015 15:58:23 +0100
In-Reply-To: <CAFEAcA-gky-HqNfTJDtj=5KtfYZ0htza3O=cu02YtRzPOgxaUQ@mail.gmail.com>
References: <CAFEAcA_2UQhFcH+yWugVVtdptT9s8BnF_jimLX_Z_X=93gADHw@mail.gmail.com>
	<1446725610.30393.23.camel@redhat.com>
	<CAFEAcA-9V5MYEWFy7W53J4yLCadeu4a+m=n_4AfzK8tqVx6dLQ@mail.gmail.com>
	<1446734529.30393.26.camel@redhat.com>
	<CAFEAcA-gky-HqNfTJDtj=5KtfYZ0htza3O=cu02YtRzPOgxaUQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers
 update from kvm/next
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Do, 2015-11-05 at 14:45 +0000, Peter Maydell wrote:
> On 5 November 2015 at 14:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Chicken & egg issue in that case because airlied (linux kernel drm
> > maintainer) asked to have the qemu changes merged before taking the
> > virtio-gpu pull request.  So I had no other chance than creating the
> > patches with not-yet upstream virtio header changes ...
> 
> Hmm. If I'd realised that at the time I'd have pushed back on it.
> We should never take code that relies on upstream kernel
> ABI that hasn't been accepted by the maintainer yet.

The reason airlied asked for qemu being upstream first is to avoid
having code in the kernel tree not accepted by qemu yet ...

So, one of the two has to go first ;)

When I did the pull requests patches had passed review on both
qemu-devel (qemu side) and dri-devel (kernel side), so this was really
just a formal "wait for qemu" thing with a very low risk of ABI changes,
and airlied pulled it into drm-next only days after it landed in
qemu/master.

cheers,
  Gerd