From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH RFC 0/5] qapi: Use common name mangling for enumeration constants
Date: Thu, 5 Nov 2015 16:29:57 +0100 [thread overview]
Message-ID: <1446737402-15597-1-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1446618049-13596-22-git-send-email-eblake@redhat.com>
I really like the simplification. The (one-time) churn is annoying.
Worthwhile?
See PATCH 3 for details.
Markus Armbruster (5):
qapi: Generate a sed script to help eliminate camel_to_upper()
Revert "qapi: Generate a sed script to help eliminate
camel_to_upper()"
qapi: Use common name mangling for enumeration constants
crypto: Drop name mangling override
Revert "qapi: allow override of default enum prefix naming"
backends/baum.c | 2 +-
backends/hostmem.c | 10 +-
backends/msmouse.c | 2 +-
backends/rng-egd.c | 2 +-
backends/testdev.c | 2 +-
balloon.c | 4 +-
block.c | 18 +-
block/backup.c | 20 +-
block/block-backend.c | 38 +--
block/commit.c | 12 +-
block/io.c | 4 +-
block/mirror.c | 22 +-
block/nbd.c | 6 +-
block/qcow2.c | 10 +-
block/quorum.c | 10 +-
block/raw-posix.c | 8 +-
block/stream.c | 10 +-
block/vmdk.c | 2 +-
blockdev-nbd.c | 2 +-
blockdev.c | 134 ++++-----
blockjob.c | 30 +-
crypto/tlscredsanon.c | 6 +-
crypto/tlscredsx509.c | 6 +-
crypto/tlssession.c | 6 +-
docs/qapi-code-gen.txt | 18 +-
docs/writing-qmp-commands.txt | 8 +-
dump.c | 28 +-
gdbstub.c | 26 +-
hmp.c | 80 +++---
hw/acpi/memory_hotplug.c | 2 +-
hw/arm/musicpal.c | 2 +-
hw/block/block.c | 2 +-
hw/block/fdc.c | 4 +-
hw/block/hd-geometry.c | 12 +-
hw/block/virtio-blk.c | 8 +-
hw/char/escc.c | 246 ++++++++--------
hw/core/qdev-properties-system.c | 2 +-
hw/display/qxl.c | 4 +-
hw/i386/kvm/i8254.c | 6 +-
hw/i386/pc.c | 10 +-
hw/i386/pc_piix.c | 10 +-
hw/i386/pc_q35.c | 10 +-
hw/ide/ahci.c | 4 +-
hw/ide/core.c | 6 +-
hw/ide/qdev.c | 2 +-
hw/input/hid.c | 26 +-
hw/input/ps2.c | 20 +-
hw/input/virtio-input-hid.c | 242 ++++++++--------
hw/mem/pc-dimm.c | 2 +-
hw/net/allwinner_emac.c | 2 +-
hw/net/cadence_gem.c | 2 +-
hw/net/dp8393x.c | 2 +-
hw/net/e1000.c | 2 +-
hw/net/eepro100.c | 2 +-
hw/net/etraxfs_eth.c | 2 +-
hw/net/fsl_etsec/etsec.c | 2 +-
hw/net/imx_fec.c | 2 +-
hw/net/lan9118.c | 2 +-
hw/net/lance.c | 2 +-
hw/net/mcf_fec.c | 2 +-
hw/net/milkymist-minimac2.c | 2 +-
hw/net/mipsnet.c | 2 +-
hw/net/ne2000-isa.c | 2 +-
hw/net/ne2000.c | 2 +-
hw/net/opencores_eth.c | 2 +-
hw/net/pcnet-pci.c | 2 +-
hw/net/rocker/rocker.c | 4 +-
hw/net/rocker/rocker_fp.c | 2 +-
hw/net/rocker/rocker_of_dpa.c | 8 +-
hw/net/rtl8139.c | 2 +-
hw/net/smc91c111.c | 2 +-
hw/net/spapr_llan.c | 2 +-
hw/net/stellaris_enet.c | 2 +-
hw/net/vhost_net.c | 18 +-
hw/net/virtio-net.c | 28 +-
hw/net/vmxnet3.c | 2 +-
hw/net/xen_nic.c | 2 +-
hw/net/xgmac.c | 2 +-
hw/net/xilinx_axienet.c | 2 +-
hw/net/xilinx_ethlite.c | 2 +-
hw/ppc/spapr_rtas.c | 2 +-
hw/scsi/scsi-disk.c | 6 +-
hw/scsi/scsi-generic.c | 4 +-
hw/timer/mc146818rtc.c | 14 +-
hw/tpm/tpm_passthrough.c | 2 +-
hw/tpm/tpm_tis.c | 4 +-
hw/usb/dev-network.c | 2 +-
hw/usb/hcd-ehci.c | 4 +-
hw/usb/redirect.c | 8 +-
hw/vfio/pci.c | 2 +-
hw/watchdog/watchdog.c | 16 +-
include/block/block_int.h | 2 +-
include/crypto/tlssession.h | 2 +-
include/migration/migration.h | 4 +-
include/qapi/error.h | 6 +-
include/ui/input.h | 8 +-
include/ui/qemu-spice.h | 2 +-
kvm-all.c | 2 +-
migration/migration.c | 170 +++++------
migration/ram.c | 4 +-
migration/rdma.c | 2 +-
migration/savevm.c | 4 +-
monitor.c | 62 ++--
net/dump.c | 4 +-
net/filter.c | 10 +-
net/hub.c | 20 +-
net/l2tpv3.c | 4 +-
net/net.c | 78 ++---
net/netmap.c | 2 +-
net/slirp.c | 4 +-
net/socket.c | 6 +-
net/tap-win32.c | 4 +-
net/tap.c | 20 +-
net/vde.c | 4 +-
net/vhost-user.c | 16 +-
numa.c | 4 +-
qapi/crypto.json | 1 -
qapi/qmp-dispatch.c | 2 +-
qdev-monitor.c | 4 +-
qemu-char.c | 54 ++--
qemu-img.c | 2 +-
qemu-nbd.c | 12 +-
qga/commands-posix.c | 34 +--
qga/commands-win32.c | 44 +--
qmp.c | 16 +-
qom/object.c | 6 +-
scripts/qapi-introspect.py | 2 +-
scripts/qapi-types.py | 6 +-
scripts/qapi-visit.py | 2 +-
scripts/qapi.py | 85 ++----
spice-qemu-char.c | 4 +-
stubs/runstate-check.c | 2 +-
target-i386/cpu.c | 2 +-
target-lm32/op_helper.c | 2 +-
tests/Makefile | 1 -
tests/qapi-schema/enum-bad-prefix.err | 1 -
tests/qapi-schema/enum-bad-prefix.exit | 1 -
tests/qapi-schema/enum-bad-prefix.json | 2 -
tests/qapi-schema/enum-bad-prefix.out | 0
tests/qapi-schema/enum-clash-member.err | 2 +-
tests/qapi-schema/enum-clash-member.json | 2 +-
tests/qapi-schema/enum-max-member.err | 2 +-
tests/qapi-schema/enum-max-member.json | 4 +-
tests/qapi-schema/qapi-schema-test.json | 5 -
tests/qapi-schema/qapi-schema-test.out | 2 -
tests/qapi-schema/test-qapi.py | 4 +-
tests/qapi-schema/union-bad-branch.err | 2 +-
tests/qapi-schema/union-bad-branch.json | 4 +-
tests/qapi-schema/union-max.err | 2 +-
tests/qapi-schema/union-max.json | 2 +-
tests/test-crypto-tlscredsx509.c | 6 +-
tests/test-crypto-tlssession.c | 12 +-
tests/test-qmp-commands.c | 2 +-
tests/test-qmp-event.c | 6 +-
tests/test-qmp-input-visitor.c | 66 ++---
tests/test-qmp-output-visitor.c | 84 +++---
tests/test-string-output-visitor.c | 4 +-
tpm.c | 14 +-
trace/qmp.c | 6 +-
ui/cocoa.m | 20 +-
ui/console.c | 22 +-
ui/gtk.c | 20 +-
ui/input-keymap.c | 274 +++++++++---------
ui/input-legacy.c | 38 +--
ui/input.c | 56 ++--
ui/sdl.c | 22 +-
ui/sdl2-keymap.h | 480 +++++++++++++++----------------
ui/sdl2.c | 20 +-
ui/spice-core.c | 4 +-
ui/spice-input.c | 20 +-
ui/vnc-auth-vencrypt.c | 2 +-
ui/vnc-ws.c | 2 +-
ui/vnc.c | 84 +++---
util/error.c | 6 +-
util/qemu-config.c | 8 +-
util/qemu-sockets.c | 32 +--
vl.c | 166 +++++------
xen-hvm.c | 4 +-
178 files changed, 1746 insertions(+), 1816 deletions(-)
delete mode 100644 tests/qapi-schema/enum-bad-prefix.err
delete mode 100644 tests/qapi-schema/enum-bad-prefix.exit
delete mode 100644 tests/qapi-schema/enum-bad-prefix.json
delete mode 100644 tests/qapi-schema/enum-bad-prefix.out
--
2.4.3
next prev parent reply other threads:[~2015-11-05 15:30 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 6:20 [Qemu-devel] [PATCH v9 00/27] alternate layout (post-introspection cleanups, subset C) Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 01/27] qapi: Use generated TestStruct machinery in tests Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 02/27] qapi: Strengthen test of TestStructList Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 03/27] qapi: Plug leaks in test-qmp-* Eric Blake
2015-11-04 8:19 ` Markus Armbruster
2015-11-04 17:24 ` Eric Blake
2015-11-04 17:44 ` Markus Armbruster
2015-11-05 13:09 ` Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 04/27] qapi: Simplify error testing " Eric Blake
2015-11-04 8:40 ` Markus Armbruster
2015-11-04 21:05 ` Eric Blake
2015-11-05 7:53 ` Markus Armbruster
2015-11-05 15:04 ` Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 05/27] qapi: More tests of alternate output Eric Blake
2015-11-04 9:04 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 06/27] qapi: Test failure in middle of array parse Eric Blake
2015-11-04 9:07 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 07/27] qapi: More tests of input arrays Eric Blake
2015-11-04 9:11 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 08/27] qapi: Provide nicer array names in introspection Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 09/27] qapi-introspect: Document lack of sorting Eric Blake
2015-11-04 10:09 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 10/27] qapi: Track simple union tag in object.local_members Eric Blake
2015-11-04 11:02 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 11/27] qapi-types: Consolidate gen_struct() and gen_union() Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 12/27] qapi-types: Simplify gen_struct_field[s] Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 13/27] qapi: Drop obsolete tag value collision assertions Eric Blake
2015-11-04 13:30 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 14/27] qapi: Fix up commit 7618b91's clash sanity checking change Eric Blake
2015-11-04 13:36 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 15/27] qapi: Simplify QAPISchemaObjectTypeMember.check() Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 16/27] qapi: Eliminate QAPISchemaObjectType.check() variable members Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 17/27] qapi: Clean up after previous commit Eric Blake
2015-11-04 13:43 ` Markus Armbruster
2015-11-04 23:03 ` Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 18/27] qapi: Factor out QAPISchemaObjectTypeMember.check_clash() Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 19/27] qapi: Check for qapi collisions of flat union branches Eric Blake
2015-11-04 19:01 ` Markus Armbruster
2015-11-04 23:11 ` Eric Blake
2015-11-04 23:25 ` Eric Blake
2015-11-05 7:59 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 20/27] qapi: Simplify QAPISchemaObjectTypeVariants.check() Eric Blake
2015-11-04 19:02 ` Markus Armbruster
2015-11-04 23:12 ` Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 21/27] qapi: Factor out QAPISchemaObjectType.check_clash() Eric Blake
2015-11-05 15:29 ` Markus Armbruster [this message]
2015-11-05 15:29 ` [Qemu-devel] [PATCH RFC 1/5] qapi: Generate a sed script to help eliminate camel_to_upper() Markus Armbruster
2015-11-05 15:29 ` [Qemu-devel] [PATCH RFC 2/5] Revert "qapi: Generate a sed script to help eliminate camel_to_upper()" Markus Armbruster
2015-11-05 15:30 ` [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants Markus Armbruster
2015-11-05 16:01 ` Daniel P. Berrange
2015-11-05 16:41 ` Eric Blake
2015-11-05 22:36 ` Eric Blake
2015-11-06 10:03 ` Markus Armbruster
2015-11-06 13:35 ` Markus Armbruster
2015-11-10 14:35 ` [Qemu-devel] What to do about QAPI naming convention violations (was: [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants) Markus Armbruster
2015-11-16 22:13 ` [Qemu-devel] blkdebug event names [was: What to do about QAPI naming convention violations] Eric Blake
2015-11-17 7:38 ` Markus Armbruster
2015-11-09 9:34 ` [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants Markus Armbruster
2015-11-09 10:53 ` Daniel P. Berrange
2015-11-05 15:30 ` [Qemu-devel] [PATCH RFC 4/5] crypto: Drop name mangling override Markus Armbruster
2015-11-05 15:30 ` [Qemu-devel] [PATCH RFC 5/5] Revert "qapi: allow override of default enum prefix naming" Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 22/27] qapi: Remove outdated tests related to QMP/branch collisions Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 23/27] qapi: Simplify visiting of alternate types Eric Blake
2015-11-05 17:01 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 24/27] qapi: Fix alternates that accept 'number' but not 'int' Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 25/27] qapi: Add positive tests to qapi-schema-test Eric Blake
2015-11-05 18:44 ` Markus Armbruster
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 26/27] qapi: Remove dead visitor code Eric Blake
2015-11-05 19:05 ` Markus Armbruster
2015-11-11 6:13 ` Eric Blake
2015-11-04 6:20 ` [Qemu-devel] [PATCH v9 27/27] qapi: Simplify visits of optional fields Eric Blake
2015-11-04 10:22 ` [Qemu-devel] [PATCH v9 00/27] alternate layout (post-introspection cleanups, subset C) Markus Armbruster
2015-11-04 15:06 ` Eric Blake
2015-11-04 18:04 ` Markus Armbruster
2015-11-05 19:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446737402-15597-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).