From: Pierre Morel <pmorel@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, pbonzini@redhat.com,
pmorel@linux.vnet.ibm.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 0/7] int128: reparing broken 128 bit memory calculations
Date: Thu, 5 Nov 2015 17:18:52 +0100 [thread overview]
Message-ID: <1446740339-31366-1-git-send-email-pmorel@linux.vnet.ibm.com> (raw)
The size of a memory area can never be negative.
It follows it must be defined as an unsigned value.
Let's modify the memory regions size to unsigned 128 integer
and modify accordingly the 128 bit arithmetic.
This makes memory size calculations easier and easier to understand.
I fear loud protest but really, it is a broken concept that
obfuscate the code.
Pierre Morel (7):
int128: use unsigned 128 bit arithmetic
memory: modify memory size for an unsigned 128bit int
128bit: adapt core files for unsigned 128bits
128bit: adapt sparc mmu_helper for UInt128
128bit: adapt VFIO for UInt128 arithmetic
128bit: adapt Virtio for UInt128 arithmetic
128bits: some HW components use 128bit arithmetic.
exec.c | 32 ++++----
hw/core/loader.c | 2 +-
hw/display/exynos4210_fimd.c | 4 +-
hw/display/framebuffer.c | 2 +-
hw/mem/pc-dimm.c | 6 +-
hw/pci-host/ppce500.c | 2 +-
hw/vfio/common.c | 20 +++---
hw/virtio/dataplane/vring.c | 2 +-
hw/virtio/vhost.c | 4 +-
hw/virtio/virtio-balloon.c | 2 +-
include/exec/memory.h | 4 +-
include/qemu/int128.h | 95 ++++++++++-----------
kvm-all.c | 16 ++--
memory.c | 184 +++++++++++++++++++++---------------------
memory_mapping.c | 2 +-
target-sparc/mmu_helper.c | 2 +-
16 files changed, 187 insertions(+), 192 deletions(-)
next reply other threads:[~2015-11-05 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 16:18 Pierre Morel [this message]
2015-11-05 16:18 ` [Qemu-devel] [PATCH 1/7] int128: use unsigned 128 bit arithmetic Pierre Morel
2015-11-05 16:18 ` [Qemu-devel] [PATCH 2/7] memory: modify memory size for an unsigned 128bit int Pierre Morel
2015-11-05 16:18 ` [Qemu-devel] [PATCH 3/7] 128bit: adapt core files for unsigned 128bits Pierre Morel
2015-11-05 16:18 ` [Qemu-devel] [PATCH 4/7] 128bit: adapt sparc mmu_helper for UInt128 Pierre Morel
2015-11-05 16:18 ` [Qemu-devel] [PATCH 5/7] 128bit: adapt VFIO for UInt128 arithmetic Pierre Morel
2015-11-05 16:18 ` [Qemu-devel] [PATCH 6/7] 128bit: adapt Virtio " Pierre Morel
2015-11-05 16:18 ` [Qemu-devel] [PATCH 7/7] 128bits: some HW components use 128bit arithmetic Pierre Morel
2015-11-05 16:32 ` [Qemu-devel] [PATCH 0/7] int128: reparing broken 128 bit memory calculations Paolo Bonzini
2015-11-06 8:36 ` Pierre Morel
2015-11-06 16:33 ` Paolo Bonzini
[not found] ` <56408B28.8070408@linux.vnet.ibm.com>
2015-11-09 12:20 ` Paolo Bonzini
2015-11-10 9:08 ` Pierre Morel
2015-11-10 12:12 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446740339-31366-1-git-send-email-pmorel@linux.vnet.ibm.com \
--to=pmorel@linux.vnet.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).