From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZubzY-0001Dm-8s for qemu-devel@nongnu.org; Fri, 06 Nov 2015 03:03:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZubzX-0000FY-FB for qemu-devel@nongnu.org; Fri, 06 Nov 2015 03:03:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZubzX-0000FU-AY for qemu-devel@nongnu.org; Fri, 06 Nov 2015 03:03:23 -0500 From: Jason Wang Date: Fri, 6 Nov 2015 16:02:49 +0800 Message-Id: <1446796969-8049-7-git-send-email-jasowang@redhat.com> In-Reply-To: <1446796969-8049-1-git-send-email-jasowang@redhat.com> References: <1446796969-8049-1-git-send-email-jasowang@redhat.com> Subject: [Qemu-devel] [PATCH V3 6/6] virtio-pci: unbreak queue_enable read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mst@redhat.com, qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, Jason Wang Guest always get zero when reading queue_enable. This violates spec. Fixing this by setting the queue_enable to true during any guest writing and setting it to zero during reset. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index e4449da..52a9e33 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1384,6 +1384,7 @@ static void virtio_pci_common_write(void *opaque, hwaddr addr, proxy->vqs[vdev->queue_sel].avail[0], ((uint64_t)proxy->vqs[vdev->queue_sel].used[1]) << 32 | proxy->vqs[vdev->queue_sel].used[0]); + proxy->vqs[vdev->queue_sel].enabled = 1; break; case VIRTIO_PCI_COMMON_Q_DESCLO: proxy->vqs[vdev->queue_sel].desc[0] = val; @@ -1831,9 +1832,15 @@ static void virtio_pci_reset(DeviceState *qdev) { VirtIOPCIProxy *proxy = VIRTIO_PCI(qdev); VirtioBusState *bus = VIRTIO_BUS(&proxy->bus); + int i; + virtio_pci_stop_ioeventfd(proxy); virtio_bus_reset(bus); msix_unuse_all_vectors(&proxy->pci_dev); + + for (i = 0; i < VIRTIO_QUEUE_MAX; i++) { + proxy->vqs[i].enabled = 0; + } } static Property virtio_pci_properties[] = { -- 2.1.4