From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuoWi-0004ht-6z for qemu-devel@nongnu.org; Fri, 06 Nov 2015 16:26:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuoWh-0006Lt-7Q for qemu-devel@nongnu.org; Fri, 06 Nov 2015 16:26:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuoWh-0006Lo-2X for qemu-devel@nongnu.org; Fri, 06 Nov 2015 16:26:27 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CA77DC0D61A3 for ; Fri, 6 Nov 2015 21:26:26 +0000 (UTC) From: Eduardo Habkost Date: Fri, 6 Nov 2015 19:20:04 -0200 Message-Id: <1446844805-14492-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1446844805-14492-1-git-send-email-ehabkost@redhat.com> References: <1446844805-14492-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] exec: Eliminate qemu_ram_free_from_ptr() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Replace qemu_ram_free_from_ptr() with qemu_ram_free(). The only difference between qemu_ram_free_from_ptr() and qemu_ram_free() is that g_free_rcu() is used instead of call_rcu(reclaim_ramblock). We can safely replace it because: * RAM blocks allocated by qemu_ram_alloc_from_ptr() always have RAM_PREALLOC set; * reclaim_ramblock(block) will do nothing except g_free(block) if RAM_PREALLOC is set at block->flags. Signed-off-by: Eduardo Habkost --- exec.c | 19 ------------------- include/exec/ram_addr.h | 1 - memory.c | 2 +- 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/exec.c b/exec.c index a028961..851959b 100644 --- a/exec.c +++ b/exec.c @@ -1672,25 +1672,6 @@ ram_addr_t qemu_ram_alloc_resizeable(ram_addr_t size, ram_addr_t maxsz, return qemu_ram_alloc_internal(size, maxsz, resized, NULL, true, mr, errp); } -void qemu_ram_free_from_ptr(ram_addr_t addr) -{ - RAMBlock *block; - - qemu_mutex_lock_ramlist(); - QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { - if (addr == block->offset) { - QLIST_REMOVE_RCU(block, next); - ram_list.mru_block = NULL; - /* Write list before version */ - smp_wmb(); - ram_list.version++; - g_free_rcu(block, rcu); - break; - } - } - qemu_mutex_unlock_ramlist(); -} - static void reclaim_ramblock(RAMBlock *block) { if (block->flags & RAM_PREALLOC) { diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 3360ac5..b0d3c10 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@ -77,7 +77,6 @@ int qemu_get_ram_fd(ram_addr_t addr); void *qemu_get_ram_block_host_ptr(ram_addr_t addr); void *qemu_get_ram_ptr(ram_addr_t addr); void qemu_ram_free(ram_addr_t addr); -void qemu_ram_free_from_ptr(ram_addr_t addr); int qemu_ram_resize(ram_addr_t base, ram_addr_t newsize, Error **errp); diff --git a/memory.c b/memory.c index c435c88..183eca5 100644 --- a/memory.c +++ b/memory.c @@ -861,7 +861,7 @@ static void memory_region_destructor_ram(MemoryRegion *mr) static void memory_region_destructor_ram_from_ptr(MemoryRegion *mr) { - qemu_ram_free_from_ptr(mr->ram_addr); + qemu_ram_free(mr->ram_addr); } static void memory_region_destructor_rom_device(MemoryRegion *mr) -- 2.1.0