From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvgFe-000119-Sb for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:48:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvgFb-0004Fw-Mm for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:48:26 -0500 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:48393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvgFb-0004Fk-2N for qemu-devel@nongnu.org; Mon, 09 Nov 2015 01:48:23 -0500 Received: from localhost by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Nov 2015 16:48:19 +1000 From: Alexey Kardashevskiy Date: Mon, 9 Nov 2015 17:47:17 +1100 Message-Id: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH qemu] spapr: Add /system-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, David Gibson Section B.6.2.1 Root Node Properties of PAPR specification defines a set of properties which shall be present in the device tree root, one of these properties is "system-id" which "should be unique across all systems and all manufacturers". Since UUID is meant to be unique, it makes sense to use it as "system-id". This adds "system-id" property to the device tree root when not empty. Signed-off-by: Alexey Kardashevskiy --- This might be expected by AIX so here is the patch. I am really not sure if it makes sense to initialize property when UUID is all zeroes as the requirement is "unique" and zero-uuid is not. --- hw/ppc/spapr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index de77528..e8b407d 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -374,6 +374,9 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base, qemu_uuid[14], qemu_uuid[15]); _FDT((fdt_property_string(fdt, "vm,uuid", buf))); + if (qemu_uuid_set) { + _FDT((fdt_property_string(fdt, "system-id", buf))); + } g_free(buf); if (qemu_get_vm_name()) { -- 2.5.0.rc3