qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/9] ahci-test: fix memory leak
Date: Mon,  9 Nov 2015 18:32:40 -0500	[thread overview]
Message-ID: <1447111968-15268-2-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1447111968-15268-1-git-send-email-jsnow@redhat.com>

Use the proper free command to detroy an AHCICommand.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/ahci-test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 59d387c..8370fa3 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -1034,14 +1034,14 @@ static void test_dma_fragmented(void)
     ahci_command_commit(ahci, cmd, px);
     ahci_command_issue(ahci, cmd);
     ahci_command_verify(ahci, cmd);
-    g_free(cmd);
+    ahci_command_free(cmd);
 
     cmd = ahci_command_create(CMD_READ_DMA);
     ahci_command_adjust(cmd, 0, ptr, bufsize, 32);
     ahci_command_commit(ahci, cmd, px);
     ahci_command_issue(ahci, cmd);
     ahci_command_verify(ahci, cmd);
-    g_free(cmd);
+    ahci_command_free(cmd);
 
     /* Read back the guest's receive buffer into local memory */
     bufread(ptr, rx, bufsize);
-- 
2.4.3

  reply	other threads:[~2015-11-09 23:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 23:32 [Qemu-devel] [PATCH 0/9] ahci: atapi qtests John Snow
2015-11-09 23:32 ` John Snow [this message]
2015-11-09 23:32 ` [Qemu-devel] [PATCH 2/9] libqos/ahci: ATAPI support John Snow
2015-11-09 23:32 ` [Qemu-devel] [PATCH 3/9] libqos/ahci: ATAPI identify John Snow
2015-11-09 23:32 ` [Qemu-devel] [PATCH 4/9] libqos/ahci: Switch to mutable properties John Snow
2015-11-09 23:32 ` [Qemu-devel] [PATCH 5/9] libqos: allow zero-size allocations John Snow
2015-11-09 23:32 ` [Qemu-devel] [PATCH 6/9] libqos/ahci: allow nondata commands for ahci_io variants John Snow
2015-11-09 23:32 ` [Qemu-devel] [PATCH 7/9] libqos/ahci: add ahci_exec John Snow
2015-11-09 23:32 ` [Qemu-devel] [PATCH 8/9] qtest/ahci: ATAPI data tests John Snow
2015-11-09 23:32 ` [Qemu-devel] [PATCH 9/9] libqos/ahci: organize header John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447111968-15268-2-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).