From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 03/15] trace: count number of enabled events
Date: Tue, 10 Nov 2015 13:31:36 +0000 [thread overview]
Message-ID: <1447162308-8517-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1447162308-8517-1-git-send-email-stefanha@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
This lets trace_event_get_state_dynamic quickly return false. Right
now there is hardly any benefit because there are also many assertions
and indirections, but the next patch will streamline all of this.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1446012388-9586-2-git-send-email-pbonzini@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
trace/control-internal.h | 4 +++-
trace/control.c | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/trace/control-internal.h b/trace/control-internal.h
index 5a8df28..271bddb 100644
--- a/trace/control-internal.h
+++ b/trace/control-internal.h
@@ -14,6 +14,7 @@
extern TraceEvent trace_events[];
+extern int trace_events_enabled_count;
static inline TraceEventID trace_event_count(void)
@@ -54,13 +55,14 @@ static inline bool trace_event_get_state_static(TraceEvent *ev)
static inline bool trace_event_get_state_dynamic(TraceEvent *ev)
{
assert(ev != NULL);
- return ev->dstate;
+ return unlikely(trace_events_enabled_count) && ev->dstate;
}
static inline void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
{
assert(ev != NULL);
assert(trace_event_get_state_static(ev));
+ trace_events_enabled_count += state - ev->dstate;
ev->dstate = state;
}
diff --git a/trace/control.c b/trace/control.c
index 995beb3..95fbc07 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -16,6 +16,8 @@
#endif
#include "qemu/error-report.h"
+int trace_events_enabled_count;
+
TraceEvent *trace_event_name(const char *name)
{
assert(name != NULL);
--
2.5.0
next prev parent reply other threads:[~2015-11-10 13:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 13:31 [Qemu-devel] [PULL 00/15] Tracing patches Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 01/15] trace: fix make foo-timestamp rules Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 02/15] trace: add make dependencies on tracetool source Stefan Hajnoczi
2015-11-10 13:31 ` Stefan Hajnoczi [this message]
2015-11-10 13:31 ` [Qemu-devel] [PULL 04/15] trace: track enabled events in a separate array Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 05/15] trace: fix documentation Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 06/15] trace: split trace_init_events out of trace_init_backends Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 07/15] trace: split trace_init_file " Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 08/15] trace: no need to call trace_backend_init in different branches now Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 09/15] trace: add "-trace enable=..." Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 10/15] trace: add "-trace help" Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 11/15] log: do not unnecessarily include qom/cpu.h Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 12/15] log: move qemu-log.c into util/ directory Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 13/15] trace: convert stderr backend to log Stefan Hajnoczi
2015-11-10 16:56 ` Peter Maydell
2015-11-11 6:41 ` Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 14/15] trace: switch default backend to "log" Stefan Hajnoczi
2015-11-10 13:31 ` [Qemu-devel] [PULL 15/15] log: add "-d trace:PATTERN" Stefan Hajnoczi
2015-11-10 13:36 ` [Qemu-devel] [PULL 00/15] Tracing patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447162308-8517-4-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).